Skip to content

Use internal ReactCompilerRuntime in react/compiler-runtime entrypoint #32054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

Use internal ReactCompilerRuntime in react/compiler-runtime entrypoint #32054

merged 1 commit into from
Jan 13, 2025

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 13, 2025

Summary

react/compiler-runtime had its own logic while src/ReactCompilerRuntime exported the runtime as a default.

Now src/ReactCompilerRuntime matches react/compiler-runtime. This is the same layout we use in the JSX runtime.

How did you test this change?

yarn build react/compiler-runtime and then diffed folders locally. Only contained version changes

`diff -bur build/ build-new/ ` 
diff --color -bur build/facebook-www/VERSION_CLASSIC build-new/facebook-www/VERSION_CLASSIC
--- build/facebook-www/VERSION_CLASSIC  2025-01-13 17:45:07
+++ build-new/facebook-www/VERSION_CLASSIC      2025-01-13 17:44:18
@@ -1 +1 @@
-19.1.0-www-classic-540efebc-20250112
\ No newline at end of file
+19.1.0-www-classic-56b463c9-20250113
\ No newline at end of file
diff --color -bur build/facebook-www/VERSION_MODERN build-new/facebook-www/VERSION_MODERN
--- build/facebook-www/VERSION_MODERN   2025-01-13 17:45:10
+++ build-new/facebook-www/VERSION_MODERN       2025-01-13 17:44:21
@@ -1 +1 @@
-19.1.0-www-modern-540efebc-20250112
\ No newline at end of file
+19.1.0-www-modern-56b463c9-20250113
\ No newline at end of file
diff --color -bur build/oss-experimental/react/package.json build-new/oss-experimental/react/package.json
--- build/oss-experimental/react/package.json   2025-01-13 17:45:10
+++ build-new/oss-experimental/react/package.json       2025-01-13 17:44:21
@@ -4,7 +4,7 @@
   "keywords": [
     "react"
   ],
-  "version": "0.0.0-experimental-540efebc-20250112",
+  "version": "0.0.0-experimental-56b463c9-20250113",
   "homepage": "https://react.dev/",
   "bugs": "https://github.com/facebook/react/issues",
   "license": "MIT",
diff --color -bur build/oss-stable/react/package.json build-new/oss-stable/react/package.json
--- build/oss-stable/react/package.json 2025-01-13 17:45:07
+++ build-new/oss-stable/react/package.json     2025-01-13 17:44:18
@@ -4,7 +4,7 @@
   "keywords": [
     "react"
   ],
-  "version": "19.1.0-canary-540efebc-20250112",
+  "version": "19.1.0-canary-56b463c9-20250113",
   "homepage": "https://react.dev/",
   "bugs": "https://github.com/facebook/react/issues",
   "license": "MIT",

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 13, 2025
@eps1lon
Use internal ReactCompilerRuntime in react/compiler-runtime entry…
5e7323c 
…point

`react/compiler-runtime` had its own logic while `src/ReactCompilerRuntime` exported the runtime as a default.

Now `src/ReactCompilerRuntime` matches `react/compiler-runtime`.
This is the same layout we use in the JSX runtime.
@eps1lon eps1lon force-pushed the sebbie/react-cr-normalize branch from 56b463c to 5e7323c Compare January 13, 2025 17:02
@eps1lon eps1lon mentioned this pull request Jan 13, 2025
Open
@react-sizebot
Copy link

react-sizebot commented Jan 13, 2025 •
edited
Loading

Comparing: af8532f...5011d61

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.73 kB 91.73 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 552.39 kB = 98.72 kB 98.27 kB
facebook-www/ReactDOM-prod.classic.js = 595.79 kB 595.79 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 586.21 kB 586.21 kB = 103.30 kB 103.30 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-art/cjs/react-art.development.js = 613.60 kB 612.22 kB = 97.65 kB 97.44 kB
oss-experimental/react-art/cjs/react-art.production.js = 321.51 kB 320.42 kB = 54.63 kB 54.41 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,043.93 kB 1,039.33 kB = 175.55 kB 174.93 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 1,043.41 kB 1,038.81 kB = 174.64 kB 174.06 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 1,027.02 kB 1,022.41 kB = 171.82 kB 171.23 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 612.41 kB 608.62 kB = 107.46 kB 106.98 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 714.33 kB 709.79 kB = 112.62 kB 111.96 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 570.91 kB 567.12 kB = 102.33 kB 101.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 552.39 kB = 98.72 kB 98.27 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 479.78 kB 475.72 kB = 76.42 kB 75.96 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 426.76 kB 422.71 kB = 68.61 kB 68.11 kB

Generated by 🚫 dangerJS against 5e7323c

@eps1lon eps1lon requested review from kassens and poteto January 13, 2025 17:16
@eps1lon eps1lon marked this pull request as ready for review January 13, 2025 17:16
@eps1lon eps1lon force-pushed the sebbie/react-cr-normalize branch from c9d5f9d to 5e7323c Compare January 13, 2025 17:17
@eps1lon eps1lon merged commit 6099351 into facebook:main Jan 13, 2025
368 checks passed
@eps1lon eps1lon deleted the sebbie/react-cr-normalize branch January 13, 2025 18:43
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@eps1lon
Use internal ReactCompilerRuntime in react/compiler-runtime entry…
4bb3447 
…point (#32054)

DiffTrain build for [6099351](6099351)
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@eps1lon
Use internal ReactCompilerRuntime in react/compiler-runtime entry…
3019ae7 
…point (#32054)

DiffTrain build for [6099351](6099351)
@vercel-release-bot vercel-release-bot mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poteto poteto poteto approved these changes

@kassens kassens Awaiting requested review from kassens

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eps1lon @react-sizebot @poteto @facebook-github-bot