[ci] Fix Flight fixture #32070
Merged
[ci] Fix Flight fixture #32070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version is not compatible with Ubuntu 24.04 which all our GH runners will switch soon to since we're using `ubuntu-latest` The version in the compiler playground is already compatible. We need at least 1.44 and there we have 1.47.
We installed an old version of `react-server-dom-webpack` without a dependency on `webpack-sources`. So Yarn decided to hoist v2 which is not compatible with the `webpack-sources` newever versions of `react-server-dom-webpack` uses. Best fix would be to ditch `predev` in favor of `file:` or `link:` protocols. `yarn install` in `predev` and `file:` protocols might be the safest option though slower. Will keep an eye out if we encounter these issues more often.
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
commented
Jan 14, 2025
Comment on lines
-7949
to
+7951
| version "0.0.0-experimental-6ebfd5b0-20240818" | ||
| resolved "https://registry.yarnpkg.com/react-server-dom-webpack/-/react-server-dom-webpack-0.0.0-experimental-6ebfd5b0-20240818.tgz#56df6a7a406a033897f9bdd33b649e6e956adcef" | ||
| integrity sha512-kDPLVKaSKwDpuxGKxWS4w0VEY1O0IUJVksfA39H7nENjmFCuHybZ6rvi+hlXgJcwV3TvVeISLSmf27yvZWUriQ== | ||
| version "0.0.0-experimental-b3a95caf-20250113" | ||
| resolved "https://registry.yarnpkg.com/react-server-dom-webpack/-/react-server-dom-webpack-0.0.0-experimental-b3a95caf-20250113.tgz#a2175829be7395acc4d25e0befbd92b233a764c6" | ||
| integrity sha512-/6/IP8sP/I1CKIBsXvuF3mQEO0Vw/Nu85QyNliCx+K6WT7plTbjpFlEnbJKWoZdh/9uQkG17IZZiGlOgExmjbA== |
There was a problem hiding this comment.
Had to regenerate this entry.
We installed an old version of react-server-dom-webpack without a dependency on webpack-sources.
So Yarn decided to hoist v2 which is not compatible with the webpack-sources newer versions of react-server-dom-webpack need.
Best fix would be to ditch predev in favor of file: or link: protocols.
yarn install in predev and file: protocols might be the safest option though slower. Will keep an eye out if we encounter these issues more often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/facebook/react/actions/runs/12777123487/job/35617499327#step:10:95
Current version is not compatible with Ubuntu 24.04 (see microsoft/playwright#30368).
The version in the compiler playground is already compatible. We need at least 1.44 and there we have 1.47.
Closes #31834