Skip to content

Conversation

@poteto
Copy link
Member

@poteto poteto commented Feb 7, 2025

There's no real reason to have 2 jobs for sizebot. It's more of a historical artifact from before the GH migration. Merging them should require one less worker needing to be provisioned and some of the extra overhead

Stack created with Sapling. Best reviewed with ReviewStack.

We don't need to wait for it to be labeled now that we have the shared maintainer check workflow.
@react-sizebot
Copy link

react-sizebot commented Feb 7, 2025

Comparing: 989b0cc...64602ca

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.48 kB 515.48 kB = 92.04 kB 92.04 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 558.52 kB 558.52 kB = 99.27 kB 99.27 kB
facebook-www/ReactDOM-prod.classic.js = 636.88 kB 636.88 kB = 111.92 kB 111.92 kB
facebook-www/ReactDOM-prod.modern.js = 627.20 kB 627.20 kB = 110.34 kB 110.34 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 620d403

There's no real reason to have 2 jobs for sizebot. It's more of a historical artifact from before the GH migration. Merging them should require one less worker needing to be provisioned and some of the extra overhead
poteto added a commit that referenced this pull request Feb 7, 2025
We don't need to wait for it to be labeled now that we have the shared
maintainer check workflow.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32332).
* #32333
* __->__ #32332
@poteto poteto merged commit 569c3b2 into main Feb 7, 2025
372 of 375 checks passed
@poteto poteto deleted the pr32333 branch February 7, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants