docs(eslint-plugin-react-hooks): clarify config details for prior versions #32498
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions This change adds more details about prior versions of the config, to help people as they migrate from legacy to flat configs across multiple versions of this plugin. At some point in the 6.0 or 7.0 cycle, it would probably make sense to re-consolidate this into a single version.
|
Comparing: 2980f27...df6bb59 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
approved these changes
Mar 3, 2025
Comment on lines
23
to
34
| #### >= 6.0.0 | ||
|
|
||
| For users of 6.0 and beyond, simply add the `recommended` config. | ||
|
|
||
| ```js | ||
| import * as reactHooks from 'eslint-plugin-react-hooks'; | ||
|
|
||
| export default [ | ||
| // ... | ||
| reactHooks.configs.recommended, | ||
| ]; | ||
| ``` |
There was a problem hiding this comment.
Hmm, I think it might be confusing to have instructions for 6.0.0 when it's not released yet. I'd suggest removing this altogether and we can add it back just as we're about to publish.
There was a problem hiding this comment.
Removed. Do you want me to go ahead and draft the follow-up change after this merges?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds more details about prior versions of the plugin's config, to help people as they migrate from legacy to flat configs across multiple versions of this plugin. At some point in the 6.0 or 7.0 cycle, it would probably make sense to re-consolidate this into a single version.
Closes #32494