fix: clarify which mobx libs are not compatible with compiler #32570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolsoftwaretyler
changed the title
…ies-for-mobx-accuracy
Member
|
Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
## Summary Right now, `react-compiler-healthcheck` flags `mobx` as a "known incompatible library". But it's not precisely *MobX* that's incompatible. It's the observer HOC that comes from `mobx-react` and `mobx-react-lite`. I've been working on [mst-use-observable](https://github.com/coolsoftwaretyler/mst-use-observable), which makes MobX-State-Tree compatible with the compiler. However, projects that use `mobx-state-tree` and `mst-use-observable` will still depend on `mobx` as a dependency. And there [have been efforts in the past to write a hook for observability](mobxjs/mobx#2566). So it's possible that MobX could become compatible, so long as authors access it with a hook, rather than the HOC. I would like to propose updating the health check to be a little more precise and flag the HOC dependencies, rather than MobX itself. Thanks in advance for your consideration! ## How did you test this change? `npx react-compiler-healthcheck` shouldn't flag on `mobx` in dependencies, but will for `mobx-react-lite` and `mobx-react`. Test suites, formatting, linting, all passed. --------- Co-authored-by: lauren <poteto@users.noreply.github.com> DiffTrain build for [ef06b54](ef06b54)
This was referenced Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now,
react-compiler-healthcheckflagsmobxas a "known incompatible library". But it's not precisely MobX that's incompatible. It's the observer HOC that comes frommobx-reactandmobx-react-lite.I've been working on mst-use-observable, which makes MobX-State-Tree compatible with the compiler. However, projects that use
mobx-state-treeandmst-use-observablewill still depend onmobxas a dependency.And there have been efforts in the past to write a hook for observability. So it's possible that MobX could become compatible, so long as authors access it with a hook, rather than the HOC.
I would like to propose updating the health check to be a little more precise and flag the HOC dependencies, rather than MobX itself.
Thanks in advance for your consideration!
How did you test this change?
npx react-compiler-healthcheckshouldn't flag onmobxin dependencies, but will formobx-react-liteandmobx-react.Test suites, formatting, linting, all passed.