Materialize the tree ID when ViewTransition name=auto consumes one #32651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
acdlite
approved these changes
Mar 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2025
…32651) ViewTransition uses the algorithm to auto-assign names. This ensures that we could animate between SSR content and client content by ensuring that the names line up. However, I missed that we need to bump the id (materialize it) when we do that. This is what function components do if they use one or more . This caused duplicate names when two ViewTransitions were nested without any siblings since they would share name. DiffTrain build for [9fde224](9fde224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewTransition uses the
useIdalgorithm to auto-assign names. This ensures that we could animate between SSR content and client content by ensuring that the names line up.However, I missed that we need to bump the id (materialize it) when we do that. This is what function components do if they use one or more
useId(). This caused duplicate names when two ViewTransitions were nested without any siblings since they would share name.