[forgive] Add code action to remove dependency array #33000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2025
github-actions
bot
added
the
React Core Team
poteto
added a commit
that referenced
this pull request
Apr 24, 2025
This was missed earlier. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32996). * #33002 * #33001 * #33000 * #32999 * #32998 * #32997 * __->__ #32996 Co-authored-by: Jordan Brown <jmbrown@meta.com>
poteto
added a commit
that referenced
this pull request
Apr 24, 2025
…32997) Emits a new event for decorating inferred effect dependencies. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32997). * #33002 * #33001 * #33000 * #32999 * #32998 * __->__ #32997 * #32996 --------- Co-authored-by: Jordan Brown <jmbrown@meta.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
This was missed earlier. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32996). * #33002 * #33001 * #33000 * #32999 * #32998 * #32997 * __->__ #32996 Co-authored-by: Jordan Brown <jmbrown@meta.com> DiffTrain build for [71d0896](71d0896)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
…32997) Emits a new event for decorating inferred effect dependencies. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32997). * #33002 * #33001 * #33000 * #32999 * #32998 * __->__ #32997 * #32996 --------- Co-authored-by: Jordan Brown <jmbrown@meta.com> DiffTrain build for [cd7d236](cd7d236)
poteto
added a commit
that referenced
this pull request
Apr 24, 2025
…32998) Draws basic decorations for inferred deps on hover. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32998). * #33002 * #33001 * #33000 * #32999 * __->__ #32998 Co-authored-by: Jordan Brown <jmbrown@meta.com>
poteto
added a commit
that referenced
this pull request
Apr 24, 2025
Refactor. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32999). * #33002 * #33001 * #33000 * __->__ #32999 Co-authored-by: Jordan Brown <jmbrown@meta.com>
Adds a new codeaction event in the compiler and handler in forgive. This allows you to remove a dependency array when you're editing a range that is within an autodep eligible function. Co-authored-by: Jordan Brown <jmbrown@meta.com>
poteto
added a commit
that referenced
this pull request
Apr 24, 2025
Compiler shouldn't crash Forgive if it can't compile (eg parse error due to being mid-typing). Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33001). * #33002 * __->__ #33001 * #33000 --------- Co-authored-by: Jordan Brown <jmbrown@meta.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Refactor. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32999). * #33002 * #33001 * #33000 * __->__ #32999 Co-authored-by: Jordan Brown <jmbrown@meta.com> DiffTrain build for [7b21c46](7b21c46)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Adds a new codeaction event in the compiler and handler in forgive. This allows you to remove a dependency array when you're editing a range that is within an autodep eligible function. Co-authored-by: Jordan Brown <jmbrown@meta.com> --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33000). * #33002 * #33001 * __->__ #33000 Co-authored-by: Jordan Brown <jmbrown@meta.com> DiffTrain build for [f765082](f765082)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new codeaction event in the compiler and handler in forgive. This allows you to remove a dependency array when you're editing a range that is within an autodep eligible function.
Co-authored-by: Jordan Brown jmbrown@meta.com
Stack created with Sapling. Best reviewed with ReviewStack.