Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

This is intended to be used by various client side resources where the transfer size is interesting to know how it'll perform in various network conditions. Not intended to be added by the server.

For now it's only added internally by DevTools itself on img/css but I'll add it from Flight Client too in a follow up.

This now shows this as the "transfer size" which is the encoded body size + headers/overhead. Where as the "fileSize" that I add to images is the decoded body size, like what you'd see on disk. This is what Chrome shows so it's less confusing if you compare Network tab and this view.

This is mainly intended to be used for client-side resources like img and
css in this case.
@sebmarkbage sebmarkbage requested a review from eps1lon August 16, 2025 17:25
@meta-cla meta-cla bot added the CLA Signed label Aug 16, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 16, 2025
…ile size

This is the data that Chrome shows for the equivalent UIs so it's more consistent.
@react-sizebot
Copy link

react-sizebot commented Aug 16, 2025

Comparing: 7a36dfe...a3ded14

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.18 kB 530.18 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.81 kB 655.86 kB = 115.30 kB 115.31 kB
facebook-www/ReactDOM-prod.classic.js = 675.58 kB 675.63 kB +0.01% 118.54 kB 118.55 kB
facebook-www/ReactDOM-prod.modern.js = 666.00 kB 666.06 kB = 116.87 kB 116.88 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +3.83% 2,024.94 kB 2,102.46 kB +3.32% 293.96 kB 303.72 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +3.83% 2,024.94 kB 2,102.46 kB +3.32% 293.96 kB 303.72 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +3.83% 2,025.12 kB 2,102.64 kB +3.32% 293.99 kB 303.75 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +3.82% 2,029.41 kB 2,106.93 kB +3.31% 294.96 kB 304.72 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +3.82% 2,029.41 kB 2,106.93 kB +3.31% 294.96 kB 304.72 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +3.82% 2,029.59 kB 2,107.11 kB +3.31% 294.98 kB 304.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +3.83% 2,024.94 kB 2,102.46 kB +3.32% 293.96 kB 303.72 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +3.83% 2,024.94 kB 2,102.46 kB +3.32% 293.96 kB 303.72 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js +3.83% 2,025.12 kB 2,102.64 kB +3.32% 293.99 kB 303.75 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +3.82% 2,029.41 kB 2,106.93 kB +3.31% 294.96 kB 304.72 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +3.82% 2,029.41 kB 2,106.93 kB +3.31% 294.96 kB 304.72 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js +3.82% 2,029.59 kB 2,107.11 kB +3.31% 294.98 kB 304.75 kB
react-native/implementations/ReactFabric-dev.fb.js = 751.93 kB 749.17 kB = 119.42 kB 118.91 kB
react-native/implementations/ReactFabric-profiling.fb.js = 451.07 kB 448.41 kB = 75.34 kB 74.83 kB
react-native/implementations/ReactFabric-prod.fb.js = 381.54 kB 378.88 kB = 65.95 kB 65.45 kB

Generated by 🚫 dangerJS against a3ded14

Since we clear the set we need to do this for updates. We already do for
suspensey images.
@sebmarkbage sebmarkbage merged commit 42b1b33 into facebook:main Aug 17, 2025
241 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants