Skip to content

Turn on null strict comparison check for xplat js #34240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Turn on null strict comparison check for xplat js #34240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ce/xplat/js/react-native-github/Libraries/Renderer/shims/ReactNativeViewConfigRegistry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noformat
* @nolint
* @flow strict-local
* @generated SignedSource<<83073425aa3f71ced2c8c51f25a25938>>
* @generated SignedSource<<1f7876c0dc0b05685a730513dc410236>>
*/

'use strict';
Expand Down Expand Up @@ -82,6 +82,8 @@ export function register(name: string, callback: () => ViewConfig): string {
typeof callback === 'function',
'View config getter callback for component `%s` must be a function (received `%s`)',
name,
/* $FlowFixMe[invalid-compare] Error discovered during Constant Condition
* roll out. See https://fburl.com/workplace/5whu3i34. */
callback === null ? 'null' : typeof callback,
);
viewConfigCallbacks.set(name, callback);
Expand Down
Loading