[DevTools] fix: keep search query in a local sync state #34423
Merged
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickhanlonii
approved these changes
Sep 9, 2025
| export default function ComponentSearchInput(): React.Node { | ||
| const [localSearchQuery, setLocalSearchQuery] = useState(''); | ||
| const {searchIndex, searchResults} = useContext(TreeStateContext); | ||
| const transitionDispatch = useContext(TreeDispatcherContext); |
There was a problem hiding this comment.
We should call this dispatchAction and standardize on that everywhere.
eps1lon
approved these changes
Sep 9, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Sep 13, 2025
When the search query changes, we kick off a transition that updates the search query in a reducer for TreeContext. The search input is also using this value for an `input` HTML element. For a larger applications, sometimes there is a noticeable delay in displaying the updated search query. This changes the approach to also keep a local synchronous state that is being updated on a change callback. DiffTrain build for [e2ba45b](facebook@e2ba45b)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Sep 13, 2025
When the search query changes, we kick off a transition that updates the search query in a reducer for TreeContext. The search input is also using this value for an `input` HTML element. For a larger applications, sometimes there is a noticeable delay in displaying the updated search query. This changes the approach to also keep a local synchronous state that is being updated on a change callback. DiffTrain build for [e2ba45b](facebook@e2ba45b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the search query changes, we kick off a transition that updates the search query in a reducer for TreeContext. The search input is also using this value for an
inputHTML element.For a larger applications, sometimes there is a noticeable delay in displaying the updated search query. This changes the approach to also keep a local synchronous state that is being updated on a change callback.