[DevTools] Wrap each tab in <Activity> if available
#34426
+136
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/09-08-_devtools_wrap_each_tab_in_activity_
branch
from
8279ea6 to
24c70b7
Compare
eps1lon
commented
Sep 9, 2025
| import type {SourceSelection} from './Editor/EditorPane'; | ||
|
|
||
| const MaybeActivity = | ||
| React.unstable_Activity || |
There was a problem hiding this comment.
If we need to disable <Activity> usage, we should just remove this branch and keep StrictMode usage in.
eps1lon
force-pushed
the
sebbie/09-08-_devtools_wrap_each_tab_in_activity_
branch
from
24c70b7 to
6086b2b
Compare
eps1lon
force-pushed
the
sebbie/09-08-_devtools_wrap_each_tab_in_activity_
branch
from
6086b2b to
f42ea4a
Compare
eps1lon
commented
Oct 3, 2025
| import type {ReactFunctionLocation, ReactCallSite} from 'shared/ReactTypes'; | ||
| import type {SourceSelection} from './Editor/EditorPane'; | ||
|
|
||
| const MaybeActivity: any = |
There was a problem hiding this comment.
I don't know how to type this. Flow treats React.Activity as a Symbol not a ElementType with certain props.
eps1lon
commented
Oct 3, 2025
|
|
||
| function HookTreeCase() { | ||
| const onClick = useCustomHook(); | ||
| const [, , onClick] = useCustomHook(); |
There was a problem hiding this comment.
drive-by fix for noisy shell errors.
hoxyq
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The divs are already
hidden={true}so we can tell React to deprioritize the hidden tabs. That way Suspense related effects like auto-scroll and suspense auto-selection don't apply while using the Components tab.I also introduced
StrictModeinto the DevTools tree to find potential issues.