[compiler][playground] (4/N) Config override panel #34436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mofeiZ, any guidance on what to do for the default config overrides? Should I just leave it empty? |
mofeiZ
reviewed
Sep 11, 2025
Comment on lines
+232
to
+243
| // Parse config overrides from config editor | ||
| let configOverrideOptions: any = {}; | ||
| const configMatch = configOverrides.match(/^\s*import.*?\n\n\((.*)\)/s); | ||
| // TODO: initialize store with URL params, not empty store | ||
| if (configOverrides.trim()) { | ||
| if (configMatch && configMatch[1]) { | ||
| const configString = configMatch[1].replace(/satisfies.*$/, '').trim(); | ||
| configOverrideOptions = new Function(`return (${configString})`)(); | ||
| } else { | ||
| throw new Error('Invalid config overrides'); | ||
| } | ||
| } |
There was a problem hiding this comment.
super nit: you can refactor this to a separate function to keep compile clean
mofeiZ
reviewed
Sep 11, 2025
| enableReanimatedCheck: true, | ||
| customOptOutDirectives: null, | ||
| target: '19', | ||
| panicThreshold: 'all_errors', |
There was a problem hiding this comment.
Let's figure out the panicThreshold override in a followup.
irrc we're currently using panicThreshold: 'none' along with a separate linting pass (to record warning diagnostics)
There was a problem hiding this comment.
Actually, I'll just remove panicThreshold for now then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the old
OVERRIDEpragma to make the source of truth for config overrides in the left-hand pane. Now, it will automatically update the output pane each time there is an edit to the config. The old pragma format is still supported, but it will be overwritten by the config pane if they are modifying the same flags. Removed the gating on the config panel so now all users will automatically be able to view it, but it will be initially collapsed.How did you test this change?
Screen.Recording.2025-09-09.at.3.50.19.PM.mov