Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2030,6 +2030,98 @@ describe('ReactInteractionTracing', () => {
});
});

// @gate enableTransitionTracing
it('background transitions report in progress boundaries and final markers', async () => {
const transitionCallbacks = {
onTransitionStart: (name, startTime) => {
Scheduler.log(`onTransitionStart(${name}, ${startTime})`);
},
onTransitionProgress: (name, startTime, endTime, pending) => {
const suspenseNames = pending.map(p => p.name || '<null>').join(', ');
Scheduler.log(
`onTransitionProgress(${name}, ${startTime}, ${endTime}, [${suspenseNames}])`,
);
},
onTransitionComplete: (name, startTime, endTime) => {
Scheduler.log(
`onTransitionComplete(${name}, ${startTime}, ${endTime})`,
);
},
onMarkerProgress: (
transitionName,
markerName,
startTime,
currentTime,
pending,
) => {
const suspenseNames = pending.map(p => p.name || '<null>').join(', ');
Scheduler.log(
`onMarkerProgress(${transitionName}, ${markerName}, ${startTime}, ${currentTime}, [${suspenseNames}])`,
);
},
onMarkerIncomplete: (
transitionName,
markerName,
startTime,
deletions,
) => {
Scheduler.log(
`onMarkerIncomplete(${transitionName}, ${markerName}, ${startTime}, [${stringifyDeletions(
deletions,
)}])`,
);
},
onMarkerComplete: (transitionName, markerName, startTime, endTime) => {
Scheduler.log(
`onMarkerComplete(${transitionName}, ${markerName}, ${startTime}, ${endTime})`,
);
},
};

function App({text}) {
return (
<React.unstable_TracingMarker name="parent">
<Suspense name="appended child">
<AsyncText text={text} />
<React.unstable_TracingMarker name="child" />
</Suspense>
</React.unstable_TracingMarker>
);
}

const root = ReactNoop.createRoot({
unstable_transitionCallbacks: transitionCallbacks,
});

await act(async () => {
root.render(<App text="One" />);
ReactNoop.expire(1000);
await advanceTimers(1000);
});

assertLog(['Suspend [One]', 'Suspend [One]']);
await act(async () => {
startTransition(() => root.render(<App text="Two" />), {
name: 'transition',
});
});

assertLog([
'Suspend [Two]',
'Suspend [Two]',
'onTransitionStart(transition, 1000)',
'onTransitionComplete(transition, 1000, 1000)',
]);

await act(async () => {
ReactNoop.expire(2000);
await advanceTimers(2000);
await resolveText('Two');
});

assertLog(['Two']);
});

// @gate enableTransitionTracing
it('marker incomplete gets called properly if child suspense marker is not part of it', async () => {
const transitionCallbacks = {
Expand Down
1 change: 1 addition & 0 deletions packages/react/index.experimental.development.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export {
unstable_startGestureTransition,
unstable_addTransitionType,
unstable_useCacheRefresh,
unstable_TracingMarker,
useId,
useCallback,
useContext,
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/ReactFeatureFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const enableDefaultTransitionIndicator = __EXPERIMENTAL__;
*/
export const enableObjectFiber: boolean = false;

export const enableTransitionTracing: boolean = false;
export const enableTransitionTracing: boolean = true;

// FB-only usage. The new API has different semantics.
export const enableLegacyHidden: boolean = false;
Expand Down
Loading