Skip to content

Conversation

@0xlau
Copy link
Contributor

@0xlau 0xlau commented Oct 23, 2025

Summary

This PR addresses a pending TODO comment left in #34499

https://github.com/facebook/react/blame/eb2f784e752ba690f032db4c3d87daac77a5a2aa/compiler/apps/playground/components/Editor/ConfigEditor.tsx#L37

This change removes the temporary workaround and replaces it with <Activity>, as originally intended.

How did you test this change?

  • Updated the component to use <Activity> directly
  • Verified the editor renders correctly in both development and production builds.
  • The <Activity> UI updates as expected.
Arc.mp4

…gement and update dependencies to latest versions
@meta-cla
Copy link

meta-cla bot commented Oct 23, 2025

Hi @0xlau!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@EugeneChoi4
Copy link
Contributor

Thanks for the @0xlau! Glad to see they finally made monaco-editor compatible with Activity. I'll be able to merge once you sign the CLA!

@EugeneChoi4 EugeneChoi4 self-requested a review October 23, 2025 15:07
@meta-cla
Copy link

meta-cla bot commented Oct 23, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Oct 23, 2025
@EugeneChoi4 EugeneChoi4 merged commit 6160773 into facebook:main Oct 23, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants