[compiler] Improve display of errors on multi-line expressions #34963
+43
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
mofeiZ
reviewed
Oct 23, 2025
| 0, | ||
| CODEFRAME_LINES_ABOVE + CODEFRAME_ABBREVIATED_SOURCE_LINES, | ||
| ), | ||
| '> ' + ' '.repeat(pipeIndex - 2) + '…', |
There was a problem hiding this comment.
nit: should we add the pipe index here?
Currently we have
2 | function Component(props) {
> 3 | const data = useMemo(() => {
| ^^^^^^^
> …
> 7 | }, [props.items?.edges?.nodes]);
| ^^^^ Could not preserve existing manual memoization
Would it look better as this?
2 | function Component(props) {
> 3 | const data = useMemo(() => {
| ^^^^^^^
> | …
> 7 | }, [props.items?.edges?.nodes]);
| ^^^^ Could not preserve existing manual memoization
There was a problem hiding this comment.
I originally did that, but it looks weird since the ellipsis isn't indented propery. I like the ellipsis in place of the pipe to show it's not continuous. 🤷♂️
poteto
approved these changes
Oct 23, 2025
mofeiZ
reviewed
Oct 23, 2025
| 0, | ||
| CODEFRAME_LINES_ABOVE + CODEFRAME_ABBREVIATED_SOURCE_LINES, | ||
| ), | ||
| '> ' + ' '.repeat(pipeIndex - 2) + '…', |
There was a problem hiding this comment.
Suggested change
| '> ' + ' '.repeat(pipeIndex - 2) + '…', | |
| '> ' + ' '.repeat(pipeIndex - 2) + '| …', |
mofeiZ
approved these changes
Oct 23, 2025
When a longer function or expression is identified as the source of an error, we currently print the entire expression in our error message. This is because we delegate to a Babel helper to print codeframes. Here, we add some checking and abbreviate the result if it spans too many lines.
|
Closes #34795 |
4 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
When a longer function or expression is identified as the source of an error, we currently print the entire expression in our error message. This is because we delegate to a Babel helper to print codeframes. Here, we add some checking and abbreviate the result if it spans too many lines. DiffTrain build for [408b38e](408b38e)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
When a longer function or expression is identified as the source of an error, we currently print the entire expression in our error message. This is because we delegate to a Babel helper to print codeframes. Here, we add some checking and abbreviate the result if it spans too many lines. DiffTrain build for [408b38e](408b38e)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 26, 2025
…ook#34963) When a longer function or expression is identified as the source of an error, we currently print the entire expression in our error message. This is because we delegate to a Babel helper to print codeframes. Here, we add some checking and abbreviate the result if it spans too many lines. DiffTrain build for [408b38e](facebook@408b38e)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 26, 2025
…ook#34963) When a longer function or expression is identified as the source of an error, we currently print the entire expression in our error message. This is because we delegate to a Babel helper to print codeframes. Here, we add some checking and abbreviate the result if it spans too many lines. DiffTrain build for [408b38e](facebook@408b38e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a longer function or expression is identified as the source of an error, we currently print the entire expression in our error message. This is because we delegate to a Babel helper to print codeframes. Here, we add some checking and abbreviate the result if it spans too many lines.