Skip to content

[Flight] Don't hang after resolving cyclic references #34988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

[Flight] Don't hang after resolving cyclic references #34988

merged 2 commits into from
Oct 27, 2025
+41 −0

Conversation

@unstubbable
Copy link
Collaborator

When we've resolved a cyclic reference in a blocked chunk, this might have fully unblocked the chunk. In that case, we must not re-add listeners to the chunk, and wake it instead (using the remaining listeners).

fixes #34751

@unstubbable
[Flight] Don't hang after resolving cyclic references
bdeaf55 
When we've resolved a cyclic reference in a blocked chunk, this might
have fully unblocked the chunk. In that case, we must not re-add
listeners to the chunk, and wake it instead (using the remaining
listeners).

fixes facebook#34751
@meta-cla meta-cla bot added the CLA Signed label Oct 27, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 27, 2025
@react-sizebot
Copy link

react-sizebot commented Oct 27, 2025 •
edited
Loading

Comparing: ba0590f...f93370e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 605.41 kB 605.41 kB = 107.22 kB 107.22 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 664.38 kB 664.38 kB = 117.09 kB 117.09 kB
facebook-www/ReactDOM-prod.classic.js = 688.25 kB 688.25 kB = 121.13 kB 121.13 kB
facebook-www/ReactDOM-prod.modern.js = 678.67 kB 678.67 kB = 119.49 kB 119.48 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js +0.64% 57.52 kB 57.89 kB +0.31% 11.33 kB 11.37 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js +0.64% 57.52 kB 57.89 kB +0.31% 11.33 kB 11.37 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.63% 57.81 kB 58.18 kB +0.32% 11.41 kB 11.45 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.63% 57.81 kB 58.18 kB +0.32% 11.41 kB 11.45 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js +0.63% 58.12 kB 58.49 kB +0.31% 11.46 kB 11.50 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.63% 58.41 kB 58.78 kB +0.31% 11.54 kB 11.57 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.61% 59.79 kB 60.15 kB +0.31% 11.82 kB 11.85 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.61% 59.79 kB 60.15 kB +0.31% 11.82 kB 11.85 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.61% 60.15 kB 60.52 kB +0.31% 11.90 kB 11.94 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.61% 60.15 kB 60.52 kB +0.31% 11.90 kB 11.94 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.61% 60.39 kB 60.75 kB +0.30% 11.94 kB 11.98 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.60% 60.76 kB 61.12 kB +0.30% 12.02 kB 12.06 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js +0.59% 65.77 kB 66.16 kB +0.27% 11.92 kB 11.95 kB
oss-stable/react-client/cjs/react-client-flight.production.js +0.59% 65.80 kB 66.19 kB +0.27% 11.94 kB 11.97 kB
oss-experimental/react-client/cjs/react-client-flight.production.js +0.59% 66.37 kB 66.75 kB +0.22% 12.06 kB 12.09 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js +0.58% 63.05 kB 63.41 kB +0.25% 12.57 kB 12.60 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js +0.58% 63.05 kB 63.41 kB +0.25% 12.57 kB 12.60 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js +0.58% 63.65 kB 64.01 kB +0.23% 12.68 kB 12.71 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.56% 66.12 kB 66.49 kB +0.27% 13.16 kB 13.20 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.56% 66.12 kB 66.49 kB +0.27% 13.16 kB 13.20 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.55% 66.14 kB 66.51 kB +0.26% 13.18 kB 13.21 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.55% 66.14 kB 66.51 kB +0.26% 13.18 kB 13.21 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.55% 66.24 kB 66.61 kB +0.22% 12.92 kB 12.95 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.55% 66.24 kB 66.61 kB +0.22% 12.92 kB 12.95 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.55% 66.72 kB 67.09 kB +0.23% 13.28 kB 13.31 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.55% 66.74 kB 67.11 kB +0.23% 13.30 kB 13.33 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.55% 66.88 kB 67.25 kB +0.23% 13.04 kB 13.07 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +0.54% 67.41 kB 67.77 kB +0.22% 13.19 kB 13.21 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +0.54% 67.41 kB 67.77 kB +0.22% 13.19 kB 13.21 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js +0.54% 68.04 kB 68.41 kB +0.20% 13.32 kB 13.34 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.53% 69.53 kB 69.90 kB +0.24% 13.60 kB 13.63 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.53% 69.53 kB 69.90 kB +0.24% 13.60 kB 13.63 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.52% 70.17 kB 70.53 kB +0.22% 13.74 kB 13.77 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.52% 70.68 kB 71.05 kB +0.24% 13.83 kB 13.86 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.52% 70.68 kB 71.05 kB +0.24% 13.83 kB 13.86 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.52% 70.71 kB 71.07 kB +0.25% 13.84 kB 13.87 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.52% 70.71 kB 71.07 kB +0.25% 13.84 kB 13.87 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.51% 71.32 kB 71.69 kB +0.22% 13.97 kB 14.00 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.51% 71.34 kB 71.71 kB +0.23% 13.98 kB 14.01 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.51% 93.66 kB 94.14 kB +0.31% 19.20 kB 19.26 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.51% 93.66 kB 94.14 kB +0.31% 19.20 kB 19.26 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.51% 94.45 kB 94.93 kB +0.30% 19.31 kB 19.37 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.24% 173.70 kB 174.12 kB +0.14% 30.22 kB 30.26 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.24% 173.72 kB 174.14 kB +0.14% 30.24 kB 30.29 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +0.24% 174.60 kB 175.02 kB +0.13% 30.40 kB 30.44 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.23% 178.32 kB 178.74 kB +0.14% 31.28 kB 31.32 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.23% 178.37 kB 178.79 kB +0.14% 31.30 kB 31.35 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.23% 178.94 kB 179.36 kB +0.14% 31.71 kB 31.75 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.23% 178.94 kB 179.36 kB +0.14% 31.71 kB 31.75 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js +0.23% 179.26 kB 179.68 kB +0.14% 31.45 kB 31.49 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js +0.23% 179.85 kB 180.27 kB +0.14% 31.85 kB 31.89 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.23% 180.28 kB 180.70 kB +0.16% 31.73 kB 31.78 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.23% 180.33 kB 180.75 kB +0.15% 31.75 kB 31.80 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.23% 181.22 kB 181.64 kB +0.16% 31.90 kB 31.95 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.23% 182.15 kB 182.57 kB +0.13% 32.21 kB 32.25 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.23% 182.15 kB 182.57 kB +0.13% 32.21 kB 32.25 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.23% 182.17 kB 182.59 kB +0.13% 32.22 kB 32.27 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.23% 182.17 kB 182.59 kB +0.13% 32.22 kB 32.27 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.23% 182.86 kB 183.28 kB +0.12% 32.22 kB 32.26 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.23% 182.91 kB 183.33 kB +0.12% 32.24 kB 32.28 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.23% 183.06 kB 183.48 kB +0.14% 32.35 kB 32.39 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.23% 183.08 kB 183.50 kB +0.14% 32.36 kB 32.41 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.23% 183.38 kB 183.80 kB +0.14% 32.35 kB 32.40 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.23% 183.38 kB 183.80 kB +0.14% 32.35 kB 32.40 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.23% 183.48 kB 183.90 kB +0.12% 32.39 kB 32.43 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.23% 183.53 kB 183.95 kB +0.12% 32.41 kB 32.45 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.23% 183.80 kB 184.21 kB +0.12% 32.39 kB 32.42 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.23% 184.25 kB 184.67 kB +0.15% 32.50 kB 32.55 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.23% 184.42 kB 184.84 kB +0.13% 32.55 kB 32.59 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.23% 185.13 kB 185.55 kB +0.14% 32.42 kB 32.47 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.23% 185.13 kB 185.55 kB +0.14% 32.42 kB 32.47 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js +0.22% 186.01 kB 186.42 kB +0.14% 32.56 kB 32.60 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.22% 186.83 kB 187.25 kB +0.14% 32.70 kB 32.74 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.22% 186.83 kB 187.25 kB +0.14% 32.70 kB 32.74 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.22% 187.71 kB 188.13 kB +0.13% 32.83 kB 32.88 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.22% 188.24 kB 188.66 kB +0.13% 32.95 kB 32.99 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.22% 188.24 kB 188.66 kB +0.13% 32.95 kB 32.99 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.22% 188.27 kB 188.68 kB +0.13% 32.96 kB 33.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.22% 188.27 kB 188.68 kB +0.13% 32.96 kB 33.01 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.22% 189.12 kB 189.54 kB +0.13% 33.09 kB 33.13 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.22% 189.14 kB 189.56 kB +0.14% 33.10 kB 33.15 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.22% 224.56 kB 225.06 kB +0.12% 49.65 kB 49.71 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.22% 224.59 kB 225.08 kB +0.12% 49.68 kB 49.73 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.22% 225.74 kB 226.24 kB +0.12% 49.87 kB 49.92 kB

Generated by 🚫 dangerJS against f93370e

@unstubbable unstubbable marked this pull request as ready for review October 27, 2025 12:12
sebmarkbage
sebmarkbage reviewed Oct 27, 2025
View reviewed changes
sebmarkbage
sebmarkbage approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid recursion.

@unstubbable unstubbable merged commit 0d721b6 into facebook:main Oct 27, 2025
240 checks passed
@unstubbable unstubbable deleted the issue-34751 branch October 27, 2025 21:06
@nextjs-bot nextjs-bot mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: RSC renderToReadableStream/createFromReadableStream gets stuck for certain objects on development

3 participants

@unstubbable @react-sizebot @sebmarkbage