Improve completeSegment for safer DOM manipulation #34996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhance completeSegment function to handle cases where segment or placeholder nodes may not exist, preventing potential DOM exceptions.
It's related to this kind of error: vercel/next.js#70048
How did you test this change?
Tried to reproduce the original issue but it's very difficult and unpredictable. Since it comes from using Next.js and the
loading.tsxSuspense boundary, it's not that straightforward to reproduce.