Skip to content

Conversation

@leog
Copy link

@leog leog commented Oct 28, 2025

Summary

Enhance completeSegment function to handle cases where segment or placeholder nodes may not exist, preventing potential DOM exceptions.

It's related to this kind of error: vercel/next.js#70048

How did you test this change?

Tried to reproduce the original issue but it's very difficult and unpredictable. Since it comes from using Next.js and the loading.tsx Suspense boundary, it's not that straightforward to reproduce.

leog added 2 commits October 27, 2025 22:17
Enhance completeSegment function to handle cases where segment or placeholder nodes may not exist, preventing potential DOM exceptions.
@meta-cla
Copy link

meta-cla bot commented Oct 28, 2025

Hi @leog!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Oct 28, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Oct 28, 2025
@meta-cla
Copy link

meta-cla bot commented Oct 28, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant