Skip to content

Conversation

@unstubbable
Copy link
Collaborator

In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables.

@meta-cla meta-cla bot added the CLA Signed label Nov 14, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Nov 14, 2025
@react-sizebot
Copy link

react-sizebot commented Nov 14, 2025

Comparing: 19b769f...abcfa76

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.16 kB 608.16 kB = 107.65 kB 107.65 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 666.18 kB 666.18 kB = 117.35 kB 117.35 kB
facebook-www/ReactDOM-prod.classic.js = 693.31 kB 693.31 kB = 121.98 kB 121.98 kB
facebook-www/ReactDOM-prod.modern.js = 683.73 kB 683.73 kB = 120.36 kB 120.36 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against abcfa76

In DEV, we need to prevent the response from being GC'd while there are
still pending chunks for ReadableSteams or pending results for
AsyncIterables.

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
@unstubbable unstubbable force-pushed the fix-stream-pending-chunks-count branch from 961c8da to abcfa76 Compare November 14, 2025 21:38
@unstubbable unstubbable merged commit fb2177c into facebook:main Nov 14, 2025
237 of 238 checks passed
@unstubbable unstubbable deleted the fix-stream-pending-chunks-count branch November 14, 2025 22:52
manNomi pushed a commit to manNomi/react that referenced this pull request Nov 15, 2025
facebook#35143)

In DEV, we need to prevent the response from being GC'd while there are
still pending chunks for ReadableSteams or pending results for
AsyncIterables.

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
github-actions bot pushed a commit to code/lib-react that referenced this pull request Nov 16, 2025
facebook#35143)

In DEV, we need to prevent the response from being GC'd while there are
still pending chunks for ReadableSteams or pending results for
AsyncIterables.

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>

DiffTrain build for [fb2177c](facebook@fb2177c)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Nov 16, 2025
facebook#35143)

In DEV, we need to prevent the response from being GC'd while there are
still pending chunks for ReadableSteams or pending results for
AsyncIterables.

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>

DiffTrain build for [fb2177c](facebook@fb2177c)
github-actions bot pushed a commit to GameRoMan/react that referenced this pull request Nov 16, 2025
facebook#35143)

In DEV, we need to prevent the response from being GC'd while there are
still pending chunks for ReadableSteams or pending results for
AsyncIterables.

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>

DiffTrain build for [fb2177c](facebook@fb2177c)
github-actions bot pushed a commit to GameRoMan/react that referenced this pull request Nov 16, 2025
facebook#35143)

In DEV, we need to prevent the response from being GC'd while there are
still pending chunks for ReadableSteams or pending results for
AsyncIterables.

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>

DiffTrain build for [fb2177c](facebook@fb2177c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants