-
Notifications
You must be signed in to change notification settings - Fork 49.9k
[Flight] Fix pending chunks count for streams & async iterables in DEV #35143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
unstubbable
merged 1 commit into
facebook:main
from
unstubbable:fix-stream-pending-chunks-count
Nov 14, 2025
Merged
[Flight] Fix pending chunks count for streams & async iterables in DEV #35143
unstubbable
merged 1 commit into
facebook:main
from
unstubbable:fix-stream-pending-chunks-count
Nov 14, 2025
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 19b769f...abcfa76 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Nov 14, 2025
In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
961c8da to
abcfa76
Compare
manNomi
pushed a commit
to manNomi/react
that referenced
this pull request
Nov 15, 2025
facebook#35143) In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 15, 2025
[diff facebook/react@93fc5740...fb2177c1](facebook/react@93fc574...fb2177c) <details> <summary>React upstream changes</summary> - facebook/react#35143 - facebook/react#35145 - facebook/react#35140 - facebook/react#35139 - facebook/react#35062 - facebook/react#35135 - facebook/react#35134 </details>
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 16, 2025
facebook#35143) In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com> DiffTrain build for [fb2177c](facebook@fb2177c)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 16, 2025
facebook#35143) In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com> DiffTrain build for [fb2177c](facebook@fb2177c)
github-actions bot
pushed a commit
to GameRoMan/react
that referenced
this pull request
Nov 16, 2025
facebook#35143) In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com> DiffTrain build for [fb2177c](facebook@fb2177c)
github-actions bot
pushed a commit
to GameRoMan/react
that referenced
this pull request
Nov 16, 2025
facebook#35143) In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com> DiffTrain build for [fb2177c](facebook@fb2177c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DEV, we need to prevent the response from being GC'd while there are still pending chunks for ReadableSteams or pending results for AsyncIterables.