-
Notifications
You must be signed in to change notification settings - Fork 49.9k
[Flight] Reduce risk of maximum call stack exceeded when emitting async sequence #35159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eps1lon
merged 1 commit into
facebook:main
from
eps1lon:sebbie/11-17-_flight_reduce_risk_of_maximum_call_stack_exceeded_when_tracking_async_debug_info
Nov 17, 2025
Merged
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9dbe4bd to
cc3d32f
Compare
sebmarkbage
approved these changes
Nov 17, 2025
Collaborator
sebmarkbage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be worth putting a limit on the collection end so that we don't keep every step of an iterative loop in memory in the first place.
In addition to avoiding emitting an I/O entry for every iteration through a loop over a stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call stack was doubled in #35005 by adding a cache wrapper.
GCC was not able to inline the implementation. We can aid GCC with inlining by refactoring the
returnin theswitchstatement to a singlereturnand multiplebreak.We still need to limit the depth manually or rewrite as an iterative function since we're effectively turning iterative, async loops into recursive calls
test plan
bundled code diff for Turbopack shows
visitAsyncNodeImplhas been inlined.