[compiler] Prevent innaccurate derivation recording on FunctionExpressions on no-derived-computation-in-effects #35173
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorge-cab
force-pushed
the
pr35173
branch
2 times, most recently
from
2f94041 to
b3f1831
Compare
josephsavona
approved these changes
Nov 19, 2025
mofeiZ
approved these changes
Nov 19, 2025
Contributor
mofeiZ
left a comment
mofeiZ
left a comment
There was a problem hiding this comment.
Let's also add an invariant that the fixpoint iteration isn't taking more than a few loops to resolve -- for now, we prefer bailouts to infinite loops in a prod build pipeline
…sions on no-derived-computation-in-effects Summary: The operands of a function expression are the elements passed as context. This means that it doesn't make sense to record mutations for them. The relevant mutations will happen in the function body, so we need to prevent FunctionExpression type instruction from running the logic for effect mutations. This was also causing some values to depend on themselves in some cases triggering an infinite loop. Also added n invariant to prevent this issue Test Plan: Added fixture test
jorge-cab
added a commit
that referenced
this pull request
Nov 20, 2025
…ns-in-effects (#35174) Summary: I missed this conditional messing things up for undefined useState() calls. We should be tracking them. I also missed a test that expect an error was not throwing. Test Plan: Update broken test --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35174). * __->__ #35174 * #35173
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…sions on no-derived-computation-in-effects (#35173) Summary: The operands of a function expression are the elements passed as context. This means that it doesn't make sense to record mutations for them. The relevant mutations will happen in the function body, so we need to prevent FunctionExpression type instruction from running the logic for effect mutations. This was also causing some values to depend on themselves in some cases triggering an infinite loop. Also added n invariant to prevent this issue Test Plan: Added fixture test --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35173). * #35174 * __->__ #35173 DiffTrain build for [7ee974d](7ee974d)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…sions on no-derived-computation-in-effects (#35173) Summary: The operands of a function expression are the elements passed as context. This means that it doesn't make sense to record mutations for them. The relevant mutations will happen in the function body, so we need to prevent FunctionExpression type instruction from running the logic for effect mutations. This was also causing some values to depend on themselves in some cases triggering an infinite loop. Also added n invariant to prevent this issue Test Plan: Added fixture test --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35173). * #35174 * __->__ #35173 DiffTrain build for [7ee974d](7ee974d)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…ns-in-effects (#35174) Summary: I missed this conditional messing things up for undefined useState() calls. We should be tracking them. I also missed a test that expect an error was not throwing. Test Plan: Update broken test --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35174). * __->__ #35174 * #35173 DiffTrain build for [7d67591](7d67591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The operands of a function expression are the elements passed as context. This means that it doesn't make sense to record mutations for them.
The relevant mutations will happen in the function body, so we need to prevent FunctionExpression type instruction from running the logic for effect mutations.
This was also causing some values to depend on themselves in some cases triggering an infinite loop. Also added n invariant to prevent this issue
Test Plan:
Added fixture test
Stack created with Sapling. Best reviewed with ReviewStack.