Skip to content

Conversation

@fraidev
Copy link
Contributor

@fraidev fraidev commented Nov 27, 2025

Reopen of #30655

Fixes #35231
Closes #35247

@meta-cla
Copy link

meta-cla bot commented Nov 27, 2025

Hi @fraidev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Nov 27, 2025
@bartlomieju
Copy link

Hey Bartek from the Deno team here - I wanted to provide additional context on this PR. We've had another report from users saying that apps using React hang in Deno. We traced down the culprit to a MessagePort that keeps the program alive - this makes sense in the browser, but in Deno we would definitely prefer to default to Node.js bundle - these days Deno behaves more like Node.js instance than a browser.

@eps1lon eps1lon changed the title fix: react-dom/server hanging on Deno [react-dom/server] Fix hanging on Deno Dec 4, 2025
@react-sizebot
Copy link

Comparing: 0526c79...ed25ea1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.36 kB 608.36 kB = 107.68 kB 107.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 667.47 kB 667.47 kB = 117.57 kB 117.57 kB
facebook-www/ReactDOM-prod.classic.js = 693.67 kB 693.67 kB = 122.07 kB 122.06 kB
facebook-www/ReactDOM-prod.modern.js = 684.10 kB 684.10 kB = 120.45 kB 120.44 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ed25ea1

@eps1lon
Copy link
Collaborator

eps1lon commented Dec 4, 2025

@bartlomieju Thanks for confirming. I'm going to merge this. I double checked that Deno supports all the modules react-dom/server needs: async_hooks (only AsyncLocalStorage), crypto, stream, and util.

Notably, async_hooks wasn't listed in https://docs.deno.com/api/node/ which I checked first. Though it is listed in https://docs.deno.com/runtime/reference/node_apis/#node%3Aasync_hooks

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@eps1lon eps1lon merged commit bf1afad into facebook:main Dec 4, 2025
238 checks passed
@Yovach
Copy link

Yovach commented Dec 4, 2025

Thanks eps1lon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Build of react-dom hangs on Deno runtime

5 participants