Skip to content

[flags] Cleanup enableActivity #35681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 1 commit into from
Feb 3, 2026
Merged

[flags] Cleanup enableActivity #35681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/react-dom/src/__tests__/ReactDOMActivity-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ describe('ReactDOMActivity', () => {
return <span prop={props.text}>{props.children}</span>;
}

// @gate enableActivity
it(
'hiding an Activity boundary also hides the direct children of any ' +
'portals it contains, regardless of how deeply nested they are',
Expand Down Expand Up @@ -100,7 +99,6 @@ describe('ReactDOMActivity', () => {
},
);

// @gate enableActivity
it(
'revealing an Activity boundary inside a portal does not reveal the ' +
'portal contents if has a hidden Activity parent',
Expand Down Expand Up @@ -151,7 +149,6 @@ describe('ReactDOMActivity', () => {
},
);

// @gate enableActivity
it('hides new portals added to an already hidden tree', async () => {
function Child() {
return <Text text="Child" />;
Expand Down Expand Up @@ -218,7 +215,6 @@ describe('ReactDOMActivity', () => {
);
});

// @gate enableActivity
it('hides new insertions inside an already hidden portal', async () => {
function Child({text}) {
useLayoutEffect(() => {
Expand Down Expand Up @@ -289,7 +285,6 @@ describe('ReactDOMActivity', () => {
);
});

// @gate enableActivity
it('reveal an inner Suspense boundary without revealing an outer Activity on the same host child', async () => {
const promise = new Promise(() => {});

Expand Down Expand Up @@ -390,7 +385,6 @@ describe('ReactDOMActivity', () => {
);
});

// @gate enableActivity
it('mounts/unmounts layout effects in portal when visibility changes (starting visible)', async () => {
function Child() {
useLayoutEffect(() => {
Expand Down Expand Up @@ -440,7 +434,6 @@ describe('ReactDOMActivity', () => {
);
});

// @gate enableActivity
it('mounts/unmounts layout effects in portal when visibility changes (starting hidden)', async () => {
function Child() {
useLayoutEffect(() => {
Expand Down
6 changes: 3 additions & 3 deletions packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ describe('FragmentRefs', () => {
});

describe('with activity', () => {
// @gate enableFragmentRefs && enableActivity
// @gate enableFragmentRefs
it('does not apply event listeners to hidden trees', async () => {
const parentRef = React.createRef();
const fragmentRef = React.createRef();
Expand Down Expand Up @@ -799,7 +799,7 @@ describe('FragmentRefs', () => {
expect(logs).toEqual(['Child 1', 'Child 3']);
});

// @gate enableFragmentRefs && enableActivity
// @gate enableFragmentRefs
it('applies event listeners to visible trees', async () => {
const parentRef = React.createRef();
const fragmentRef = React.createRef();
Expand Down Expand Up @@ -835,7 +835,7 @@ describe('FragmentRefs', () => {
expect(logs).toEqual(['Child 1', 'Child 2', 'Child 3']);
});

// @gate enableFragmentRefs && enableActivity
// @gate enableFragmentRefs
it('handles Activity modes switching', async () => {
const fragmentRef = React.createRef();
const fragmentRef2 = React.createRef();
Expand Down
2 changes: 0 additions & 2 deletions packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3668,7 +3668,6 @@ describe('ReactDOMServerPartialHydration', () => {
expect(ref.current.innerHTML).toBe('Hidden child');
});

// @gate enableActivity
it('a visible Activity component is surrounded by comment markers', async () => {
const ref = React.createRef();

Expand Down Expand Up @@ -3706,7 +3705,6 @@ describe('ReactDOMServerPartialHydration', () => {
expect(ref.current).toBe(span);
});

// @gate enableActivity
it('a hidden Activity component is skipped over during server rendering', async () => {
const visibleRef = React.createRef();

Expand Down
Loading
Loading