Skip to content

Conversation

remekoh
Copy link

@remekoh remekoh commented Oct 31, 2016

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

Update from Original - 08/15/2016

Update from Original - 08/15/2016
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@gaearon
Copy link
Collaborator

gaearon commented Oct 31, 2016

Not clear what this PR is supposed to do: it's empty and has no description.

@remekoh
Copy link
Author

remekoh commented Oct 31, 2016

I am keeping my forked repo up to date with facebook:master

@gaearon
Copy link
Collaborator

gaearon commented Oct 31, 2016

You don't need to send PRs to the original repo for this 😉

@kevinzwhuang
Copy link
Contributor

@remekoh Here's a good article on updating your forked repo - https://robots.thoughtbot.com/keeping-a-github-fork-updated

Running this should do the trick:

git checkout master
git remote add upstream https://github.com/facebook/react.git
git fetch upstream
git rebase upstream/master

@gaearon
Copy link
Collaborator

gaearon commented Oct 31, 2016

@kevinzwhuang Thank you so much for linking to the article! I was on mobile but should've waited with commenting and done that.

@kevinzwhuang
Copy link
Contributor

No problem, glad to help! 😄

@remekoh
Copy link
Author

remekoh commented Oct 31, 2016

Thanks, guys!

I appreciate the help!

Newbie here... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants