[Fiber] [WIP] Errors shouldn't interfere with scheduling #8166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this actually changes any behavior because of the way findNextUnitOfWork works, but I think this is easier to follow.
A bit of restructuring so that setState uses whatever the current priority context is, like top-level render already does. Renamed defaultPriority to priorityContext, and added a new variable called defaultPriorityContext. Having two separate variables allows the default to be changed without interfering with the current context.
I'll turn this on in ReactDOMFiber once I figure out batchedUpdates.
Almost working...
Without this fix, in non-batched mode, the update is scheduled first and synchronously flushed before the callback is added to the queue. The callback isn't called until the next flush.
Implements batchedUpdates and exposes as unstable_batchedUpdates. All nested synchronous updates are automatically batched.
Turns out this isn't necessary. Simpler to keep it as one field.
Instead we'll branch on the priority level, like in scheduleWork.
This removes the only potentially recursive call in Fiber codebase by moving the error handling outside commitAllWork(), and thus, outside performUnitOfWork().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #8127.
This is probably incomplete and there may be ways to simplify.
It removes the recursion from error handling and makes scheduling resilient to errors.