Call setState callbacks enqueued in cWM #8207
Conversation
| expect(x).toBe(y); | ||
| // We expose refs with a bunch of internal props. Yuck. But this should not | ||
| // be TopLevelWrapper. | ||
| expect(x._currentElement.props.foo).toBe('foo'); |
There was a problem hiding this comment.
Can we check x.props.foo if this is fiber while we're at it?
There was a problem hiding this comment.
This is RN so I don't think we can right now.
There was a problem hiding this comment.
It will fail regardless now but once we fix RN this could pass. Otherwise we later have to go through this test. 15 minutes saved later.
There was a problem hiding this comment.
Yeah but the module is called ReactDOMFeatureFlags. Want me to do it anyway?
There was a problem hiding this comment.
Actually I will just change this to make sure it is the same as a ref on the View.
There was a problem hiding this comment.
Oh I see what you're saying. Just land it as is NBD.
Also fixes return value of ReactNativeMount and moves that callback to be after cDM instead of after all updates.
| expect(UIManager.updateView).toBeCalledWith(3, 'View', { foo: 'bar' }); | ||
| }); | ||
|
|
||
| it('should be able to create and update a native component', () => { |
There was a problem hiding this comment.
this name is duplicated. a bit confusing.
There was a problem hiding this comment.
copy pasta, will fix
|
Is this comment outdated now and can be removed? |
Also fixes return value of ReactNativeMount and moves that callback to be after cDM instead of after all updates.
5 participants
Depends on #8204.
Also fixes return value of ReactNativeMount and moves that callback to be after cDM instead of after all updates.