CIFuzz dogfood #1992
CIFuzz dogfood #1992
Conversation
|
Hi @Leo-Neat! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
That sounds nifty! I think we would be interested in such a thing. |
|
@felixhandte It looks like signing the facebook CLA would take some effort and time. So if you are willing, I think it would be easier if you landed it yourselves. I don't plan to make any more patches to your repo other than the one suggested. The rest of the implementation is generic and lives in the OSS-Fuzz repo. |
|
Yeah, we'd definitely be interested. I'll put up a PR later today. Is there documentation for this feature somewhere? |
|
@Leo-Neat I put up a bad PR in #1994 and the CIFuzz found the issue in this run https://github.com/facebook/zstd/actions/runs/37230566. But where does the artifact get uploaded? |
@terrelln In order for the workflow to upload failure artifacts it needs to have dry-run set to false in both the build and run actions. This is because dry-run mode prevents failures, but a failure is what triggers the artifact upload. One way to test this is set dry-run: false temporarily and re-run the same test. Then the test will fail and an artifact with a test case and stack trace will be uploaded. |
|
Thanks @Leo-Neat! Assuming things go well in the next week or so we'll turn off dry-run mode. I'm really excited for this! |
|
@terrelln No problem! Please reach out if you have any issues or UX comments and I would be happy to address them. |
4 participants
OSS-Fuzz was wondering if zstd would dogfood CIFuzz,
a new feature being rolled out in OSS-Fuzz. It allows for pull
requests to be fuzzed in CI using fuzz targets enabled in OSS-Fuzz.
It will be active in dry_run mode meaning that it will never fail.