This repository was archived by the owner on Apr 28, 2023. It is now read-only.
Cleanup cache .cuda artifacts and more fixes to python test #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaning up more cache .cuda artifacts left in codebase and docs. Also fixing python test more.
prigoyal
force-pushed
the
fix-tests-cleanup
branch
from
e2b8e85 to
12fe566
Compare
nicolasvasilache
approved these changes
Apr 26, 2018
Contributor
nicolasvasilache
left a comment
nicolasvasilache
left a comment
There was a problem hiding this comment.
Some of those disappeared in the global refactoring, I'll rebase on top of your changes then.
It seems my grep rules missed some occurrences in this interim PR, sorry about that!
In any case it's great to have a second set of eyes on this, thanks for this!
Contributor
Author
|
thanks for the review. merging PR to facilitate CI testing :) |
Contributor
|
FMI, could you comment on what in this PR helps bring back CI? |
Contributor
Author
|
for sure. the test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaning up more cache .cuda artifacts left in codebase and docs. Also fixing python test more. I stumbled upon these while debugging CI more. Hopefully these are last set of changes to help bring back CI
partially helps #338