Skip to content

Conversation

@kondela
Copy link
Contributor

@kondela kondela commented Aug 28, 2020

Adds options to config in order to enable/disable random horizontal/vertical flipping for image augmentation.

Feature labeled as enhancement and requested by 1513

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2020
@kondela
Copy link
Contributor Author

kondela commented Aug 31, 2020

Pipeline failed on test_nms_rotated_0_degree_cuda located in tests/layers/test_nms_rotated.py. However, when I ran it locally it passed all the tests. After a closer inspection it appears that the _create_tensors method is non deterministic as it contains torch.rand which once in a while produces values that make the test fail. Confirmed after running the test 200 times it failed once.

I guess this would deserve a new PR that would make test behavior deterministic. Meanwhile, I propose to simply rerun the failed pipeline, what do you think @ppwwyyxx?

Copy link
Contributor

@ppwwyyxx ppwwyyxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this test occasionally fails. Instead of making it deterministic we would actually like to understand the root cause of that and whether there is a small bug behind. For now we can just ignore that in this PR

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppwwyyxx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2020
Summary:
Adds options to config in order to enable/disable random horizontal/vertical flipping for image augmentation.

Feature labeled as _enhancement_ and requested by [1513](#1513)

Pull Request resolved: #1976

Reviewed By: rbgirshick

Differential Revision: D23590862

Pulled By: ppwwyyxx

fbshipit-source-id: ea364c48bdbe8a7cc49ac0cf03426793e7d43eb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants