Fix semantic rendering #1507
Merged
Fix semantic rendering #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikwijmans
requested review from
bigbike,
jturner65,
aclegg3 and
Skylion007
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Sep 30, 2021
Skylion007
approved these changes
Sep 30, 2021
…into fix-instance-rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Semantic rendering requires an activeSemenaticSceneGraph, not a semenaticScene. The former is the Magnum SceneGraph used for rendering while the latter contains information about semantic annotations. We are currently checking for the latter while needing the former.
How Has This Been Tested
Via the new test.
Types of changes
Bug fix (non-breaking change which fixes an issue)