Skip to content

Conversation

@neochief
Copy link

How about structuring implementations in the factory method as a separate package, to show the actual value to the student? I'm looking forward t your comments.

@fadeevab
Copy link
Owner

@neochief Thank you for patch, I think it makes sense. Just let's make a bit of refactoring over the patch structure: it's a little bit overcomplicated because of "too much of decoupling" :).

  1. Move the app/* files into the render-dialog root.
  2. Rename lib.rs to mod.rs in the submodules.
  3. Now, you can rid of Cargo.toml in the submodules.
  4. Make modules visible to the project:
    mod init;
    mod gui;
    mod html_gui;
    mod windows_gui;
    
    use init::initialize;
    
    fn main() {.....}
  5. Run cargo fmt

@fadeevab
Copy link
Owner

fadeevab commented Aug 28, 2022

@neochief Check it out: PR #3
I believe we can simplify like that, and I applied your README, comments, and other suggestions.

@neochief neochief closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants