Skip to content

Single Model.update() instead of update_from_kwargs and setattr_and_save #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2025
Merged

Single Model.update() instead of update_from_kwargs and setattr_and_save #822

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4178df6
Single Model.update() instead of update_from_kwargs and setattr_and_save
f213 Aug 27, 2025
4c1d4ac
Whitespace fix
f213 Aug 27, 2025
5229bdc
Make mypy happy
f213 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions {{ cookiecutter.name }}/src/app/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@ def __str__(self) -> str:
def get_contenttype(cls) -> ContentType:
return ContentType.objects.get_for_model(cls)

def update_from_kwargs(self, **kwargs: dict[str, Any]) -> None:
"""A shortcut method to update model instance from the kwargs."""
def update(self, **kwargs: "Any") -> "models.Model":
for key, value in kwargs.items():
setattr(self, key, value)

def setattr_and_save(self, key: str, value: Any) -> None:
"""Shortcut for testing -- set attribute of the model and save"""
setattr(self, key, value)
self.save()
self.save(update_fields=kwargs.keys())

return self

@classmethod
def get_label(cls) -> str:
Expand Down