Skip to content

First and second batch of translation updates + improvements#58

Closed
skycommand wants to merge 3 commits intofarag2:masterfrom
skycommand:patch-1
Closed

First and second batch of translation updates + improvements#58
skycommand wants to merge 3 commits intofarag2:masterfrom
skycommand:patch-1

Conversation

@skycommand
Copy link
Copy Markdown

@skycommand skycommand commented Aug 25, 2020

I've read the script until line 1374 today before running out of time. In addition to the translation updates, I've made the following improvements too:

  • Merged lines 57 to 64 into a single line.
  • Changed the $CheckpointDescription at line 157 (now 153) to "Windows 10 Setup Script.ps1" You DO NOT need to include the date into it; the date is automatically added.
  • At line 618, the script checks whether the Windows registry already has Task Manager settings, before trying to run Task Manager
  • At line 648, I fixed a typo in the Registry key
  • At line 660, I asked Get-Package to use the "Programs" provider only and not waste time with others.
  • At line 824, the script now displays the actual location of %SystemDrive$\Temp before asking the user whether they want to change the location of their temp folder.

Update (30 August 2020): I've read the script until the end. In addition to the translation updates, I've made the following improvements too:

  • Activation of the old "automatic Registry backup" is disabled because this deprecated feature is now dangerous. With Windows 10 version 20H1, Microsoft made a change to the way Registry transaction logs (for the lack of better terms) are created. The old "automatic Registry backup" does not see these new changes. As such, its backups are useless. Microsoft suggests System Restore instead. I suggest a proper backup tool, like Macrium Reflect.

I've read the script until line 1374 today before running out of time. In addition to the translation updates, I've made the following improvements too:

- Merged lines 57 to 64 into a single line.
- Changed the $CheckpointDescription at line 157 (now 153) to "Windows 10 Setup Script.ps1" You **DO NOT** need to include the date into it; the date is automatically added.
- At line 618, the script checks whether the Windows registry already has Task Manager settings, before trying to run Task Manager
- At line 648, I fixed a typo in the Registry key
- At line 660, I asked Get-Package to use the "Programs" provider only and not waste time with others. 
- At line 824, the script now displays the actual location of %SystemDrive$\Temp before asking the user whether they want to change the location of their temp folder.
I've read the script until the end. In addition to the translation updates, I've made the following improvements too:

- Activation of the old "automatic Registry backup" is disabled because this deprecated feature is now dangerous. With Windows 10 version 20H1, Microsoft made a change to have Registry transaction logs (for the lack of better terms) are created. The old "automatic Registry backup" does not see these new changes. As such, its backups are useless. Microsoft suggests System Restore instead. I suggest a proper backup tool, like Macrium Reflect.
@skycommand skycommand changed the title First batch of translation updates + improvements First and second batch of translation updates + improvements Aug 30, 2020
@farag2
Copy link
Copy Markdown
Owner

farag2 commented Aug 31, 2020

Thanks! I'm back to work. 🧑‍💼

@skycommand
Copy link
Copy Markdown
Author

Well, I'm off to playing some video games after so many days. Reading the script and interpreting it was mind-numbing. It was the most advanced script I have ever seen.

@farag2
Copy link
Copy Markdown
Owner

farag2 commented Aug 31, 2020

Well, I'm off to playing some video games after so many days. Reading the script and interpreting it was mind-numbing. It was the most advanced script I have ever seen.

You haven't read code of the GUI version being developed by my colleague! :) Thanks a lot!

@farag2 farag2 closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants