Skip to content

Added more void casts to prevent unused warnings. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2017
Merged

Added more void casts to prevent unused warnings. #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
098f979
Added void casts to prevent unused warnings.
timohl Jan 26, 2017
ffa6e76
Uncommented reference in catches.
timohl Jan 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/message/migfra/task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void Task_container::load(const YAML::Node &node)
std::string type;
try {
fast::load(type, node["task"]);
} catch (const std::exception /*&e*/) {
} catch (const std::exception &/*e*/) {
throw Task_container::no_task_exception("Cannot find key \"task\" to load Task from YAML.");
}
if (type == "start vm") {
Expand Down
2 changes: 1 addition & 1 deletion src/mqtt_communicator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ std::string MQTT_communicator::get_message(const std::string &topic, const std::
auto &subscription = subscriptions.at(topic);
lock.unlock();
return subscription->get_message(duration, actual_topic);
} catch (const std::out_of_range /*&e*/) {
} catch (const std::out_of_range &/*e*/) {
throw std::out_of_range("Topic not found in subscriptions.");
}
}
Expand Down
8 changes: 4 additions & 4 deletions test/optional_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ struct Task_tester :
fructose_assert_eq(tag, p.get_tag());
fructose_assert_exception(p.get(), std::runtime_error);
fructose_assert_exception(*p, std::runtime_error);
fructose_assert_exception(p->id, std::runtime_error);
fructose_assert_exception((void) p->id, std::runtime_error);
p = Person(1);
fructose_assert(p);
fructose_assert(p.is_valid());
fructose_assert_no_exception(p.get());
fructose_assert_no_exception(*p);
fructose_assert_no_exception((*p).id);
fructose_assert_no_exception(p.get().id);
fructose_assert_no_exception(p->id);
fructose_assert_no_exception((void) (*p).id);
fructose_assert_no_exception((void) p.get().id);
fructose_assert_no_exception((void) p->id);
fructose_assert((*p).id == 1);
fructose_assert(p.get().id == 1);
fructose_assert(p->id == 1);
Expand Down