Skip to content

Conversation

@hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Apr 21, 2019

I could be wrong but in the definition of the Runner class in the __call__ method, is the variable res supposed to be initialized to True? Maybe I'm missing something but the way I'm understanding it this code will always return false?

    def __call__(self, cb_name):
        res = False
        for cb in sorted(self.cbs, key=lambda x: x._order): res = cb(cb_name) and res
        return res

Thanks

Is this supposed to be set to True?
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/fastai/fastai_docs/pull/107

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

@hamelsmu
Copy link
Member Author

Wow this review-notebook app is so cool. I have been missing out my entire life.

@jph00 jph00 merged commit a4b232c into fastai:master May 19, 2019
@jph00
Copy link
Member

jph00 commented May 19, 2019

Thanks! Sorry for the slow merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants