Skip to content

Conversation

@babs
Copy link

@babs babs commented Sep 25, 2025

Following a discussion, this version handles both PORT and FASTAPI_<ops>.

Rework of #216 to handle all contraints (hosting provider and generic containerization orchestration)

…y added `PORT` envvar

Signed-off-by: Damien Degois <damien@degois.info>
…ng precedence

Signed-off-by: Damien Degois <damien@degois.info>
@patrick91
Copy link
Contributor

Hi again @babs 😊

I really appreciate your eagerness to contribute to FastAPI CLI! As mentioned in #216, I don't think these environment variables are that helpful, so I'd close the PR for now 😊

@patrick91 patrick91 closed this Sep 26, 2025
@babs
Copy link
Author

babs commented Sep 26, 2025

@patrick91 , if environment variable support is to be adopted, it should fully embrace the philosophy of containerization rather than being limited to SaaS usage only. Focusing exclusively on fastapi-cli use within Docker environments adapted solely for SaaS risks overlooking broader, real-world use cases. I initiated this discussion earlier this year and volunteered to create this PR because I believe many users would greatly benefit from increased flexibility beyond SaaS, alignment with established containerization best practices, and a platform- and service-agnostic approach.

Currently, limiting environment variable support guides developers building containers but restricts operators managing those containers from customizing behavior according to their specific environmental constraints. This limitation reduces the practical utility of fastapi-cli across diverse operational contexts.

As promoted in the official FastAPI documentation, I believe it should converge more fully with the broader ecosystem it serves.

I hope this clarifies the importance of fully supporting environment variables for all CLI options to provide flexibility and align with best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants