Skip to content

Conversation

@tiangolo
Copy link
Member

🔧 Upgrade Material for MkDocs and remove insiders

@github-actions
Copy link
Contributor

📝 Docs preview

Last commit 6c2a126 at: https://1304de4a.fastapitiangolo.pages.dev

@tiangolo tiangolo marked this pull request as ready for review November 20, 2025 10:44
@tiangolo tiangolo merged commit be5a631 into master Nov 20, 2025
44 checks passed
@tiangolo tiangolo deleted the no-insiders branch November 20, 2025 10:45
@njsbhu
Copy link

njsbhu commented Nov 20, 2025

  1. Timeouts & concurrency: add timeout-minutes per job and concurrency at workflow level so repeated pushes cancel older runs. Saves runner minutes.
concurrency:
  group: docs-${{ github.ref }}
  cancel-in-progress: true
  1. timeout under jobs
jobs:
  changes:
    runs-on: ubuntu-latest
    timeout-minutes: 20
  1. timeout under langs
  langs:
    needs: changes
    runs-on: ubuntu-latest
    timeout-minutes: 15
  1. updated build-docs - Fail fast vs allowed skips: your docs-all-green job uses allowed-skips: build-docs. Decide whether skips are acceptable — it can cause branch protection false positives if build was intentionally skipped.
  build-docs:
    needs: [changes, langs]
    # Run only if docs changed AND langs list is non-empty
    if: ${{ needs.changes.outputs.docs == 'true' && needs.langs.outputs.langs != '[]' }}
    runs-on: ubuntu-latest
    timeout-minutes: 60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants