fastapi favicon causes cross-origin error in Swagger

[KlausGlueckert]

Since including "https://fastapi.tiangolo.com/img/favicon.png", Swagger / Redoc will throw JS Errors because cross-origin

Javascript Error when loading Swagger /docs

VM33:1 Fetch API cannot load https://fastapi.tiangolo.com/img/favicon.png. Request mode is "same-origin" but the URL's origin is not same as the request origin http://<ip>:80

Could you include the icon locally or allow overriding the url in the

app 

thank you!

[tiangolo]

Humm, I have never seen that error. Where are you seeing it? In what browser? On which port? Maybe you could add some screenshots that show the issue.

Otherwise, you can customize the docs with: https://fastapi.tiangolo.com/advanced/extending-openapi/#self-hosting-javascript-and-css-for-docs

[KlausGlueckert]

@tiangolo I think this might be caused if you set your CORS very restrictive. I havent updated to the latest FastAPI yet with our stack. Once we have, I will check, if the error still exsits or otherwise impleent the solution from your link (this seems a good solution). Just be aware of cross-domain requests when loading CSS/js/logo files from a CDN. I would receommend that you just include them locally in the Docker built for the future.

[tiangolo]

Thanks for replying back! ☕

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

[github-actions]

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.