Skip to content

🌐 Add German translation for docs/features.md #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2021
Merged

🌐 Add German translation for docs/features.md #3699

merged 5 commits into from
Sep 13, 2021

Conversation

mawassk
Copy link
Contributor

@mawassk mawassk commented Aug 13, 2021

No description provided.

@tiangolo
Copy link
Member

Awesome! Thanks for your contribution. 🚀

These translations depend mainly on having more people that speak the language review them, once I have two reviews approving a translation PR I can merge it.

I just created a new issue to track these translations, you can comment there and subscribe, and probably also check if there are other PRs by others you could review. 🤓

#3716

@tiangolo tiangolo added awaiting-review lang-all Translations lang-de German translations labels Aug 18, 2021
@github-actions github-actions bot mentioned this pull request Aug 18, 2021
Closed
@codecov
Copy link

codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #3699 (43d1938) into master (25a4828) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3699   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       410    +1     
  Lines        10244     10281   +37     
=========================================
+ Hits         10244     10281   +37
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
tests/test_read_with_orm_mode.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a4828...43d1938. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9f3fe85 at: https://611d0fc9b5ffd20e08ee084d--fastapi.netlify.app

d-e-h-i-o
d-e-h-i-o approved these changes Aug 20, 2021
View reviewed changes
Copy link

@d-e-h-i-o d-e-h-i-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found this one issue. Otherwise looks great!

rogerbrinkmann
rogerbrinkmann suggested changes Aug 28, 2021
View reviewed changes
@mawassk
Copy link
Contributor Author

mawassk commented Aug 29, 2021

Thank you for your feedback @rogerbrinkmann! I updated my PR 🚀

@tiangolo
Copy link
Member

Awesome, thank you @mawassk! 🍰 ☕

And thanks for the reviews @rogerbrinkmann and @d-e-h-i-o! 👏

@github-actions
Copy link
Contributor

📝 Docs preview for commit 43d1938 at: https://613f825dbe6ef90d00736a91--fastapi.netlify.app

@tiangolo tiangolo merged commit 3a786a7 into fastapi:master Sep 13, 2021
@mawassk mawassk deleted the german-translation-features branch September 13, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rogerbrinkmann rogerbrinkmann rogerbrinkmann approved these changes

@d-e-h-i-o d-e-h-i-o d-e-h-i-o approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-de German translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mawassk @tiangolo @rogerbrinkmann @d-e-h-i-o