Body for RedirectResponse

[mrkovalchuk]

Good day.

I found some conflict (as I see it) between RedirectResponse class and openapi schema.

class RedirectResponse(Response):
    def __init__(
        self,
        url: typing.Union[str, URL],
        status_code: int = 307,
        headers: dict = None,
        background: BackgroundTask = None,
    ) -> None:
        super().__init__(
            content=b"", status_code=status_code, headers=headers, background=background
        )
        self.headers["location"] = quote_plus(str(url), safe=":/%#?&=@[]!$&'()*+,;")

We can't define a content. But only 304 status code (of the redirect codes) really can't have a body.

This fact and STATUS_CODES_WITH_NO_BODY = {..., 304} makes a trouble with openapi schema validation.

May be, we should allow set a content with check for the 304 status_code (and nullify content if it is)?

[ycd]

I believe 204 is fine since it is named No Content, also RFC states it clearly by saying it must not include a message-body.

The 204 response MUST NOT include a message-body, and thus is always terminated by the first empty line after the header fields.

[mrkovalchuk]

I believe 204 is fine since it is named No Content, also RFC states it clearly by saying it must not include a message-body.

The 204 response MUST NOT include a message-body, and thus is always terminated by the first empty line after the header fields.

It's issue only about 3XX responses. About 307 especially.

For clearly, I delete other status codes mentioned in first message. Thanks.

[tiangolo]

Hmm, I'm not sure I understand what you need or what you are suggesting 🤔

Could you please create a minimal self-contained example that shows your use case? ☕

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

[github-actions[bot]]

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.