Skip to content

✅ Remove unused type ignores since SQLAlchemy 2.0.44 #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

✅ Remove unused type ignores since SQLAlchemy 2.0.44 #1613

merged 1 commit into from
Oct 21, 2025

Conversation

@svlandeg
Copy link
Member

Since SQLAlchemy 2.0.44, we can remove two unnecessary type: ignore statements. If we don't remove them, mypy will fail our CI with

sqlmodel/orm/session.py:116: error: Unused "type: ignore" comment  [unused-ignore]
sqlmodel/ext/asyncio/session.py:132: error: Unused "type: ignore" comment  [unused-ignore]
Found 2 errors in 2 files

tiangolo
tiangolo approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tiangolo tiangolo merged commit 95c6b2d into fastapi:main Oct 21, 2025
27 checks passed
@svlandeg svlandeg deleted the fix/unused_ignores branch October 21, 2025 09:33
@svlandeg svlandeg mentioned this pull request Oct 21, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiangolo tiangolo tiangolo approved these changes

Assignees

No one assigned

Labels

internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@svlandeg @tiangolo