Consider adding Click license text and SPDX identifier to .dist-info metadata #1817
Replies: 1 comment
-
|
Thanks for bringing this up! As you mentioned we are in fact distributing the original license with Click's code files, which is the main requirement of the BSD-3 license. The current state of things is sort of an intermediate working version. In the future, the intention is to replace the Click's vendored implementation with functionality implemented from scratch to support additional features in Typer's code base directly (see also my reply on #1816). So the current state is not the final state we expect, only a transition to make sure people's Typer apps continue working with the least friction possible. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
First Check
Example Code
Description
Since Typer vendored Click in 0.26.0, the contents of
typer/_clickare licensedBSD-3-Clause, in contrast to the “main” license ofMIT. The applicable license text is included astyper/_click/LICENSE.txt, which is both good and necessary. However, I think that theproject.licensefield inpyproject.tomlshould be updated from"MIT"to"MIT AND BSD-3-Clause"to reflect the complete set of licenses that apply to the project. Ideally,"typer/_click/LICENSE.txt"could also be added toproject.license-filesso that both applicable license texts are distributed in the dist-info metadata.Operating System
Linux
Operating System Details
I maintain the
python-typerpackage in Fedora, but this discussion applies across all operating systems.Project Version
0.26.5
Python Version
Python 3.14.5
Additional Context
I would be happy to provide a PR implementing these suggestions.
Beta Was this translation helpful? Give feedback.
All reactions