Skip to content

🧑‍💻 Handle HTTP errors when streaming build logs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

🧑‍💻 Handle HTTP errors when streaming build logs #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 27 additions & 26 deletions src/fastapi_cloud_cli/commands/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,42 +345,43 @@ def _wait_for_deployment(
with toolkit.progress(
next(messages), inline_logs=True, lines_to_show=20
) as progress:
for line in _stream_build_logs(deployment.id):
time_elapsed = time.monotonic() - started_at
with handle_http_errors(progress=progress):
for line in _stream_build_logs(deployment.id):
time_elapsed = time.monotonic() - started_at

data = json.loads(line)
data = json.loads(line)

if "message" in data:
progress.log(Text.from_ansi(data["message"].rstrip()))
if "message" in data:
progress.log(Text.from_ansi(data["message"].rstrip()))

if data.get("type") == "complete":
progress.log("")
progress.log(
f"🐔 Ready the chicken! Your app is ready at [link={deployment.url}]{deployment.url}[/link]"
)
if data.get("type") == "complete":
progress.log("")
progress.log(
f"🐔 Ready the chicken! Your app is ready at [link={deployment.url}]{deployment.url}[/link]"
)

progress.log("")
progress.log("")

progress.log(
f"You can also check the app logs at [link={deployment.dashboard_url}]{deployment.dashboard_url}[/link]"
)
progress.log(
f"You can also check the app logs at [link={deployment.dashboard_url}]{deployment.dashboard_url}[/link]"
)

break
break

if data.get("type") == "failed":
progress.log("")
progress.log(
f"😔 Oh no! Something went wrong. Check out the logs at [link={deployment.dashboard_url}]{deployment.dashboard_url}[/link]"
)
raise typer.Exit(1)
if data.get("type") == "failed":
progress.log("")
progress.log(
f"😔 Oh no! Something went wrong. Check out the logs at [link={deployment.dashboard_url}]{deployment.dashboard_url}[/link]"
)
raise typer.Exit(1)

if time_elapsed > 30:
messages = cycle(LONG_WAIT_MESSAGES) # pragma: no cover
if time_elapsed > 30:
messages = cycle(LONG_WAIT_MESSAGES) # pragma: no cover

if (time.monotonic() - last_message_changed_at) > 2:
progress.title = next(messages) # pragma: no cover
if (time.monotonic() - last_message_changed_at) > 2:
progress.title = next(messages) # pragma: no cover

last_message_changed_at = time.monotonic() # pragma: no cover
last_message_changed_at = time.monotonic() # pragma: no cover


def _setup_environment_variables(toolkit: RichToolkit, app_id: str) -> None:
Expand Down
1 change: 1 addition & 0 deletions src/fastapi_cloud_cli/utils/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def __init__(self) -> None:

super().__init__(
base_url=settings.base_api_url,
timeout=httpx.Timeout(20),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the opportunity to update this too, mainly for staging, but default timeout was 5 seconds 😊

headers={
"Authorization": f"Bearer {token}",
"User-Agent": f"fastapi-cloud-cli/{__version__}",
Expand Down
Loading