more conditions to terminate integration test earlier #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
apesternikov
changed the title
michaelschiff
approved these changes
Apr 14, 2024
| } | ||
| tails[id].Close() | ||
| delete(tails, id) | ||
| }) |
There was a problem hiding this comment.
The error handling strategy within the Watch function's callback does not account for handling errors that may occur during the execution of the callback. This could lead to silent failures where errors are not propagated or logged, making debugging difficult. It's recommended to implement a strategy for error handling within the callback, such as logging errors or using a channel to propagate errors back to the caller for handling.
apesternikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration test should also be terminated early