-
Notifications
You must be signed in to change notification settings - Fork 17
create_gitops_prs: added a new bazel_flag argument #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @apesternikov, could you please have a look to this PR? Thank you for your work! |
|
@eko thank you for contributing! |
24d2ad6 to
218b40f
Compare
218b40f to
49d290c
Compare
Signed-off-by: Vincent Composieux <vincent@composieux.fr>
49d290c to
4bafa37
Compare
|
Hello @apesternikov, thank you for taking time to review! You're completely right, I just moved to a I just made a test with both single and multiple arguments on my CI/CD and it works great. |
apesternikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Add a missing
--configargument when runningcreate_gitops_prstarget.Description
When the
create_gitops_prs.goGo script is launched, it internally executes abazel run <target>command.I have an issue in my CI/CD because of that. I need to specify a config tag such as:
bazel run --config=ci <target>.This PR adds the needed argument. I hope more people will enjoy it.
How Has This Been Tested?
I have forked the repository and tested id on my real CI/CD and I can confirm that it works well.
There is absolutely no breaking change as the config is only added if given.
Types of changes
Checklist: