Skip to content

Conversation

@eko
Copy link
Contributor

@eko eko commented Aug 8, 2025

Add a missing --config argument when running create_gitops_prs target.

Description

When the create_gitops_prs.go Go script is launched, it internally executes a bazel run <target> command.

I have an issue in my CI/CD because of that. I need to specify a config tag such as: bazel run --config=ci <target>.

This PR adds the needed argument. I hope more people will enjoy it.

How Has This Been Tested?

I have forked the repository and tested id on my real CI/CD and I can confirm that it works well.

There is absolutely no breaking change as the config is only added if given.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@eko
Copy link
Contributor Author

eko commented Aug 10, 2025

Hi @apesternikov, could you please have a look to this PR?

Thank you for your work!

@apesternikov
Copy link
Contributor

@eko thank you for contributing!
Also, thanks for catching an important use case.
Would you mind slightly modifying your MR? There are more than single command line parameter to set bazel configuration. Could you please create a flag bazel_flag and accumulate multiple values into a slice that would be passed to bazel command line. Usage: --bazel_flag --config=ci or --bazel_flag --config --bazel_flag ci

@eko eko force-pushed the added-bazel-config branch from 24d2ad6 to 218b40f Compare August 12, 2025 06:56
@eko eko force-pushed the added-bazel-config branch from 218b40f to 49d290c Compare August 12, 2025 06:59
Signed-off-by: Vincent Composieux <vincent@composieux.fr>
@eko eko force-pushed the added-bazel-config branch from 49d290c to 4bafa37 Compare August 12, 2025 07:10
@eko
Copy link
Contributor Author

eko commented Aug 12, 2025

Hello @apesternikov, thank you for taking time to review!

You're completely right, I just moved to a --bazel_flag that is allowed to be passed multiple times.

I just made a test with both single and multiple arguments on my CI/CD and it works great.

@apesternikov apesternikov self-requested a review August 13, 2025 13:43
Copy link
Contributor

@apesternikov apesternikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@apesternikov apesternikov changed the title create_gitops_prs: added a new bazel_config argument create_gitops_prs: added a new bazel_flag argument Aug 13, 2025
@apesternikov apesternikov merged commit 5c21bfb into fasterci:main Aug 13, 2025
2 checks passed
@eko eko deleted the added-bazel-config branch August 13, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants