Skip to content

Conversation

@CarterLi
Copy link
Member

No description provided.

@CarterLi CarterLi requested a review from Copilot November 16, 2025 01:30
Copilot finished reviewing on behalf of CarterLi November 16, 2025 01:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This release fixes three regressions introduced in v2.55.0:

  • Parallel command execution randomly breaking due to SIGCHLD signal handling
  • Incorrect dylib search path condition on macOS preventing dynamic library loading
  • Uninitialized order field in display options

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CMakeLists.txt Updates version to 2.55.1 and fixes macOS dylib rpath logic (changed from NOT to positive condition)
CHANGELOG.md Documents the three bugfixes included in this patch release
debian/changelog.tpl Adds changelog entry for the new release
src/modules/display/display.c Initializes the order field in display options
src/detection/gpu/gpu_linux.c Adds options parameter to FF_UNUSED macro to prevent compiler warnings
src/detection/gpu/gpu_drm.c Adds options parameter to FF_UNUSED macro to prevent compiler warnings
src/common/processing_linux.c Simplifies poll error handling and removes EAGAIN check (no longer needed with blocked SIGCHLD)
src/common/init.c Replaces SIGCHLD signal handler with signal blocking to fix race conditions in command execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CarterLi CarterLi merged commit 917f784 into master Nov 16, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants