Skip to content

Conversation

@CarterLi
Copy link
Member

Will do player tomorrow if I have time

@LinusDierheimer
Copy link
Collaborator

I can't test it, but code wise it seems fine. Thanks a lot!

@LinusDierheimer LinusDierheimer merged commit 6f2748e into fastfetch-cli:master Sep 19, 2022
@LinusDierheimer
Copy link
Collaborator

I noticed that you used objective c, but i don't see anything that requires the use of it. Why not stay in c?

And is the media remote framework guaranteed to exist on MacOS? If yes we can just link against it.

@CarterLi
Copy link
Member Author

CarterLi commented Sep 19, 2022

I noticed that you used objective c, but i don't see anything that requires the use of it. Why not stay in c?

using of <CoreFoundation/CoreFoundation.h> requires obj-c ( which is a obj-c header file )

Also notice the usage of ^ block syntax ( may also be provided as a C extension )

And is the media remote framework guaranteed to exist on MacOS?

Yes, at least in newer version

If yes we can just link against it.

No. /System/Library/PrivateFrameworks/MediaRemote.framework/MediaRemote is a private framework, which cannot be directly linked against. MediaRemote.framework isn't in the framework search path, -framework /System/Library/PrivateFrameworks/MediaRemote.framework doesn't work and MediaRemote.framework provides no header files.

@LinusDierheimer
Copy link
Collaborator

Then i am completely fine with the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants