Skip to content

Conversation

@CarterLi
Copy link
Member

@CarterLi CarterLi commented Sep 23, 2022

I still hope fastfetch can support Windows some day.

My few efforts: CarterLi@2a65be0

Copy link
Collaborator

@LinusDierheimer LinusDierheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the GH actions file too, to build with libcjson support in the linux build.

@LinusDierheimer LinusDierheimer merged commit 6efe186 into fastfetch-cli:master Sep 23, 2022
@LinusDierheimer
Copy link
Collaborator

Thanks again!

@CarterLi
Copy link
Member Author

Well adding dependency libcjson-dev didn't seem to make cmake find libcjson on Ubuntu, maybe

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f157d0b..3256cb1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -376,7 +376,7 @@ ff_lib_enable(GLX glx)
 ff_lib_enable(OSMESA osmesa)
 ff_lib_enable(OPENCL OpenCL)
 ff_lib_enable(LIBPLIST libplist-2.0)
-ff_lib_enable(LIBCJSON libcjson)
+ff_lib_enable(LIBCJSON libcjson libcjson1)

@LinusDierheimer
Copy link
Collaborator

LinusDierheimer commented Sep 23, 2022

https://packages.ubuntu.com/focal/amd64/libcjson-dev/filelist
https://packages.ubuntu.com/impish/amd64/libcjson-dev/filelist

Ubuntu starts shipping the package config file with 20.08, and gh uses 20.04, so no chance for us to build with support sadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants