Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 5, 2024

we already check if value is equal to NULL in ffStrbufAppendNS

@CarterLi CarterLi merged commit e98e2a3 into fastfetch-cli:dev May 5, 2024
CarterLi added a commit that referenced this pull request May 5, 2024
CarterLi added a commit that referenced this pull request May 5, 2024
@apocelipes
Copy link
Contributor

The checks are not redundant because value and its data will be used as parameters. Skipping the check leds to UBs.
ffStrbufAppendNS's check is also not redundant because value's data could be NULL or empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants