Lots and lots of warnings... #4
Description
Some of these warnings could be cleared:
../src/xorfilter_plus.h: In function ‘uint64_t xorfilter_plus::popcountLinear(uint64_t*, uint64_t, uint64_t)’:
../src/xorfilter_plus.h:174:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Wsign-compare]
for (int i = 0; i < lastword; i++) {
~~^~~~~~~~~~
../src/xorfilter_plus.h: In constructor ‘xorfilter_plus::Poppy::Poppy(uint64_t*, uint64_t)’:
../src/xorfilter_plus.h:189:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
for(int i=0; i<bitsArraySize; i++) {
~^~~~~~~~~~~~~~
../src/xorfilter_plus.h:274:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Wsign-compare]
for(int i=0; i<num_bits; i++) {
~^~~~~~~~~
../src/xorfilter_plus.h:280:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Wsign-compare]
for(int i=0; i<num_bits; i++) {
~^~~~~~~~~
In file included from ../src/gqf/gqf_cpp.h:12,
from bulk-insert-and-query.cc:40:
../src/gqf/gqf_int.h: At global scope:
../src/gqf/gqf_int.h:59:38: warning: type attributes ignored after type is already defined [-Wattributes]
struct __attribute__ ((__packed__)) qfblock;
^~~~~~~
bulk-insert-and-query.cc: In static member function ‘static void FilterAPI<MortonFilter>::AddAll(std::vector<long unsigned int>, size_t, size_t, FilterAPI<MortonFilter>::Table*)’:
bulk-insert-and-query.cc:349:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
for(int i=start; i<end; i++) {
~^~~~
In file included from bulk-insert-and-query.cc:23:
../src/morton/compressed_cuckoo_filter.h: In instantiation of ‘CompressedCuckoo::CompressedCuckooFilter<t_slots_per_bucket, t_fingerprint_len_bits, t_ota_len_bits, t_block_size_bits, t_target_compression_ratio, t_read_counters_method, t_read_fingerprints_method, t_reduction_method, t_alternate_bucket_selection_method, t_morton_ota_hashing_method, t_resizing_enabled, t_remap_enabled, t_collision_resolution_enabled, t_morton_filter_functionality_enabled, t_block_fullness_array_enabled, t_handle_conflicts, t_fingerprint_comparison_method>::block_t* CompressedCuckoo::CompressedCuckooFilter<t_slots_per_bucket, t_fingerprint_len_bits, t_ota_len_bits, t_block_size_bits, t_target_compression_ratio, t_read_counters_method, t_read_fingerprints_method, t_reduction_method, t_alternate_bucket_selection_method, t_morton_ota_hashing_method, t_resizing_enabled, t_remap_enabled, t_collision_resolution_enabled, t_morton_filter_functionality_enabled, t_block_fullness_array_enabled, t_handle_conflicts, t_fingerprint_comparison_method>::allocate_cache_aligned_storage(uint64_t) [with short unsigned int t_slots_per_bucket = 3; short unsigned int t_fingerprint_len_bits = 8; short unsigned int t_ota_len_bits = 16; short unsigned int t_block_size_bits = 512; __int128 unsigned t_target_compression_ratio = 0x80000000000000001eaa8eb463497b00; CompressedCuckoo::CounterReadMethodEnum t_read_counters_method = (CompressedCuckoo::CounterReadMethodEnum)0; CompressedCuckoo::FingerprintReadMethodEnum t_read_fingerprints_method = (CompressedCuckoo::FingerprintReadMethodEnum)0; CompressedCuckoo::ReductionMethodEnum t_reduction_method = (CompressedCuckoo::ReductionMethodEnum)0; CompressedCuckoo::AlternateBucketSelectionMethodEnum t_alternate_bucket_selection_method = (CompressedCuckoo::AlternateBucketSelectionMethodEnum)1; CompressedCuckoo::OverflowTrackingArrayHashingMethodEnum t_morton_ota_hashing_method = (CompressedCuckoo::OverflowTrackingArrayHashingMethodEnum)2; bool t_resizing_enabled = false; bool t_remap_enabled = true; bool t_collision_resolution_enabled = true; bool t_morton_filter_functionality_enabled = true; bool t_block_fullness_array_enabled = false; bool t_handle_conflicts = true; CompressedCuckoo::FingerprintComparisonMethodEnum t_fingerprint_comparison_method = (CompressedCuckoo::FingerprintComparisonMethodEnum)0; CompressedCuckoo::CompressedCuckooFilter<t_slots_per_bucket, t_fingerprint_len_bits, t_ota_len_bits, t_block_size_bits, t_target_compression_ratio, t_read_counters_method, t_read_fingerprints_method, t_reduction_method, t_alternate_bucket_selection_method, t_morton_ota_hashing_method, t_resizing_enabled, t_remap_enabled, t_collision_resolution_enabled, t_morton_filter_functionality_enabled, t_block_fullness_array_enabled, t_handle_conflicts, t_fingerprint_comparison_method>::block_t = Morton::Block<512, 8, long unsigned int>; uint64_t = long unsigned int]’:
../src/morton/compressed_cuckoo_filter.h:493:18: required from ‘void CompressedCuckoo::CompressedCuckooFilter<t_slots_per_bucket, t_fingerprint_len_bits, t_ota_len_bits, t_block_size_bits, t_target_compression_ratio, t_read_counters_method, t_read_fingerprints_method, t_reduction_method, t_alternate_bucket_selection_method, t_morton_ota_hashing_method, t_resizing_enabled, t_remap_enabled, t_collision_resolution_enabled, t_morton_filter_functionality_enabled, t_block_fullness_array_enabled, t_handle_conflicts, t_fingerprint_comparison_method>::heap_allocate_table_and_summed_counters_buffer() [with short unsigned int t_slots_per_bucket = 3; short unsigned int t_fingerprint_len_bits = 8; short unsigned int t_ota_len_bits = 16; short unsigned int t_block_size_bits = 512; __int128 unsigned t_target_compression_ratio = 0x80000000000000001eaa8eb463497b00; CompressedCuckoo::CounterReadMethodEnum t_read_counters_method = (CompressedCuckoo::CounterReadMethodEnum)0; CompressedCuckoo::FingerprintReadMethodEnum t_read_fingerprints_method = (CompressedCuckoo::FingerprintReadMethodEnum)0; CompressedCuckoo::ReductionMethodEnum t_reduction_method = (CompressedCuckoo::ReductionMethodEnum)0; CompressedCuckoo::AlternateBucketSelectionMethodEnum t_alternate_bucket_selection_method = (CompressedCuckoo::AlternateBucketSelectionMethodEnum)1; CompressedCuckoo::OverflowTrackingArrayHashingMethodEnum t_morton_ota_hashing_method = (CompressedCuckoo::OverflowTrackingArrayHashingMethodEnum)2; bool t_resizing_enabled = false; bool t_remap_enabled = true; bool t_collision_resolution_enabled = true; bool t_morton_filter_functionality_enabled = true; bool t_block_fullness_array_enabled = false; bool t_handle_conflicts = true; CompressedCuckoo::FingerprintComparisonMethodEnum t_fingerprint_comparison_method = (CompressedCuckoo::FingerprintComparisonMethodEnum)0]’
../src/morton/compressed_cuckoo_filter.h:324:5: required from ‘CompressedCuckoo::CompressedCuckooFilter<t_slots_per_bucket, t_fingerprint_len_bits, t_ota_len_bits, t_block_size_bits, t_target_compression_ratio, t_read_counters_method, t_read_fingerprints_method, t_reduction_method, t_alternate_bucket_selection_method, t_morton_ota_hashing_method, t_resizing_enabled, t_remap_enabled, t_collision_resolution_enabled, t_morton_filter_functionality_enabled, t_block_fullness_array_enabled, t_handle_conflicts, t_fingerprint_comparison_method>::CompressedCuckooFilter(uint64_t) [with short unsigned int t_slots_per_bucket = 3; short unsigned int t_fingerprint_len_bits = 8; short unsigned int t_ota_len_bits = 16; short unsigned int t_block_size_bits = 512; __int128 unsigned t_target_compression_ratio = 0x80000000000000001eaa8eb463497b00; CompressedCuckoo::CounterReadMethodEnum t_read_counters_method = (CompressedCuckoo::CounterReadMethodEnum)0; CompressedCuckoo::FingerprintReadMethodEnum t_read_fingerprints_method = (CompressedCuckoo::FingerprintReadMethodEnum)0; CompressedCuckoo::ReductionMethodEnum t_reduction_method = (CompressedCuckoo::ReductionMethodEnum)0; CompressedCuckoo::AlternateBucketSelectionMethodEnum t_alternate_bucket_selection_method = (CompressedCuckoo::AlternateBucketSelectionMethodEnum)1; CompressedCuckoo::OverflowTrackingArrayHashingMethodEnum t_morton_ota_hashing_method = (CompressedCuckoo::OverflowTrackingArrayHashingMethodEnum)2; bool t_resizing_enabled = false; bool t_remap_enabled = true; bool t_collision_resolution_enabled = true; bool t_morton_filter_functionality_enabled = true; bool t_block_fullness_array_enabled = false; bool t_handle_conflicts = true; CompressedCuckoo::FingerprintComparisonMethodEnum t_fingerprint_comparison_method = (CompressedCuckoo::FingerprintComparisonMethodEnum)0; uint64_t = long unsigned int]’
bulk-insert-and-query.cc:321:58: required from here
../src/morton/compressed_cuckoo_filter.h:458:13: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘using block_t = struct Morton::Block<512, 8, long unsigned int>’ {aka ‘struct Morton::Block<512, 8, long unsigned int>’}; use assignment or value-initialization instead [-Wclass-memaccess]
memset(storage, 0x0, allocation_size);
~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/morton/compressed_cuckoo_filter.h:42,
from bulk-insert-and-query.cc:23:
../src/morton/block.h:49:8: note: ‘using block_t = struct Morton::Block<512, 8, long unsigned int>’ {aka ‘struct Morton::Block<512, 8, long unsigned int>’} declared here
struct Block{ // Assuming block size is a multiple of atom_t's size in bytes
^~~~~
In file included from bulk-insert-and-query.cc:34:
../src/xorfilter_plus.h: In constructor ‘xorfilter_plus::Poppy::Poppy(uint64_t*, uint64_t)’:
../src/xorfilter_plus.h:186:19: warning: ignoring return value of ‘int posix_memalign(void**, size_t, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
posix_memalign((void **) &bits_, kCacheLineSize, (bitsArraySize + 16) * sizeof(uint64_t));
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/xorfilter_plus.h:215:19: warning: ignoring return value of ‘int posix_memalign(void**, size_t, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
posix_memalign((void **) &l1Entries_, kCacheLineSize, l1EntryCount_ * sizeof(uint64_t));
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/xorfilter_plus.h:218:19: warning: ignoring return value of ‘int posix_memalign(void**, size_t, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
posix_memalign((void **) &l2Entries_, kCacheLineSize, l2EntryCount_ * sizeof(uint64_t));
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~