-
Notifications
You must be signed in to change notification settings - Fork 167
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Following https://github.com/lemire/fast_float/pull/15, we have honest performance in the more-than-19-digits scenario, but anyone reading the code paths will see that there is obvious (non highly technical) room from speed gains.
This is not a priority because beating speed records in that unusual scenario is not very important, and we are still typically going to beat standard libraries. We just want to avoid really bad performance.
The parse_decimal is subject to optimizations:
- We do not need to reparse the exponent, we could recover it from our pass in parse_number_string.
- We could stop after 19 digits and try to bail out using the fast slow path from https://github.com/lemire/fast_float/pull/15
If someone is looking for some fun work...
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers